Make net::IOBuffer 64-bit safe

Make net::IOBuffer 64-bit safe

BUG=166496
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179730

[jschuh, 2013-01-30 18:49:50]

Trivial checks to validate the sizes for IOBuffer and StringIOBuffer.

[Ryan Hamilton, 2013-01-30 20:33:53]

lgtm, though I'm curious if you've thought about the change I proposed.  I
suspect you have, and that it's actually a bad idea for some reason.

https://codereview.chromium.org/12091071/diff/1/net/base/io_buffer.h
File net/base/io_buffer.h (right):

https://codereview.chromium.org/12091071/diff/1/net/base/io_buffer.h#newcode118
net/base/io_buffer.h:118: int size() const { return
static_cast<int>(string_data_.size()); }
You're way more familiar with the 64 bit safe-ification, but I wonder if it
would make more sense for this method to return size_t since the length of the
string is limited to size_t.

[jschuh, 2013-01-30 20:54:13]

https://codereview.chromium.org/12091071/diff/1/net/base/io_buffer.h
File net/base/io_buffer.h (right):

https://codereview.chromium.org/12091071/diff/1/net/base/io_buffer.h#newcode118
net/base/io_buffer.h:118: int size() const { return
static_cast<int>(string_data_.size()); }
I *really* *really* wanted to, but it bleeds through too much. So, I'm putting
it off until start a longterm project to cure the intfection.

[commit-bot: I haz the power, 2013-01-30 20:57:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/12091071/1

[commit-bot: I haz the power, 2013-01-30 23:18:33]

Change committed as 179730