Make net::IOBuffer 64-bit safe

net/base/io_buffer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_IO_BUFFER_H_
 #define NET_BASE_IO_BUFFER_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
@@ skipping 97 matching lines @@
 
   int size_;
 };
 
 // This is a read only IOBuffer.  The data is stored in a string and
 // the IOBuffer interface does not provide a proper way to modify it.
 class NET_EXPORT StringIOBuffer : public IOBuffer {
  public:
   explicit StringIOBuffer(const std::string& s);
 
-  int size() const { return string_data_.size(); }
+  int size() const { return static_cast<int>(string_data_.size()); }

[Ryan Hamilton, 2013/01/30 20:33:53]

You're way more familiar with the 64 bit safe-ification, but I wonder if it
would make more sense for this method to return size_t since the length of the
string is limited to size_t.

[jschuh, 2013/01/30 20:54:14]

I *really* *really* wanted to, but it bleeds through too much. So, I'm putting
it off until start a longterm project to cure the intfection.

 
  private:
   virtual ~StringIOBuffer();
 
   std::string string_data_;
 };
 
 // This version wraps an existing IOBuffer and provides convenient functions
 // to progressively read all the data.
 //
@@ skipping 106 matching lines @@
  public:
   explicit WrappedIOBuffer(const char* data);
 
  protected:
   virtual ~WrappedIOBuffer();
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_IO_BUFFER_H_