src/mark-compact.cc - Issue 12091018: Put making embedded maps in optimized code weak behind a flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mark-compact.cc

Issue 12091018: Put making embedded maps in optimized code weak behind a flag. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mark-compact.cc

diff --git a/src/mark-compact.cc b/src/mark-compact.cc

index 7d611c1c1c6b5b97e1cc61b4d952c71f72c5ab3d..bfb4031f3e42831d0c381efa05f542f2117c56e9 100644

--- a/src/mark-compact.cc

+++ b/src/mark-compact.cc

@@ -85,7 +85,8 @@ class VerifyMarkingVisitor: public ObjectVisitor {

void VisitEmbeddedPointer(RelocInfo* rinfo) {

ASSERT(rinfo->rmode() == RelocInfo::EMBEDDED_OBJECT);

- if (rinfo->host()->kind() != Code::OPTIMIZED_FUNCTION ||

+ if (!FLAG_weak_embedded_maps_in_optimized_code ||

+ rinfo->host()->kind() != Code::OPTIMIZED_FUNCTION ||

!rinfo->target_object()->IsMap() ||

!Map::cast(rinfo->target_object())->CanTransition()) {

VisitPointer(rinfo->target_object_address());

« no previous file with comments | « src/lithium.cc ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »