Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Side by Side Diff: src/mark-compact.cc

Issue 12091018: Put making embedded maps in optimized code weak behind a flag. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/lithium.cc ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 for (Object** current = start; current < end; current++) { 78 for (Object** current = start; current < end; current++) {
79 if ((*current)->IsHeapObject()) { 79 if ((*current)->IsHeapObject()) {
80 HeapObject* object = HeapObject::cast(*current); 80 HeapObject* object = HeapObject::cast(*current);
81 CHECK(HEAP->mark_compact_collector()->IsMarked(object)); 81 CHECK(HEAP->mark_compact_collector()->IsMarked(object));
82 } 82 }
83 } 83 }
84 } 84 }
85 85
86 void VisitEmbeddedPointer(RelocInfo* rinfo) { 86 void VisitEmbeddedPointer(RelocInfo* rinfo) {
87 ASSERT(rinfo->rmode() == RelocInfo::EMBEDDED_OBJECT); 87 ASSERT(rinfo->rmode() == RelocInfo::EMBEDDED_OBJECT);
88 if (rinfo->host()->kind() != Code::OPTIMIZED_FUNCTION || 88 if (!FLAG_weak_embedded_maps_in_optimized_code ||
89 rinfo->host()->kind() != Code::OPTIMIZED_FUNCTION ||
89 !rinfo->target_object()->IsMap() || 90 !rinfo->target_object()->IsMap() ||
90 !Map::cast(rinfo->target_object())->CanTransition()) { 91 !Map::cast(rinfo->target_object())->CanTransition()) {
91 VisitPointer(rinfo->target_object_address()); 92 VisitPointer(rinfo->target_object_address());
92 } 93 }
93 } 94 }
94 }; 95 };
95 96
96 97
97 static void VerifyMarking(Address bottom, Address top) { 98 static void VerifyMarking(Address bottom, Address top) {
98 VerifyMarkingVisitor visitor; 99 VerifyMarkingVisitor visitor;
(...skipping 3811 matching lines...) Expand 10 before | Expand all | Expand 10 after
3910 while (buffer != NULL) { 3911 while (buffer != NULL) {
3911 SlotsBuffer* next_buffer = buffer->next(); 3912 SlotsBuffer* next_buffer = buffer->next();
3912 DeallocateBuffer(buffer); 3913 DeallocateBuffer(buffer);
3913 buffer = next_buffer; 3914 buffer = next_buffer;
3914 } 3915 }
3915 *buffer_address = NULL; 3916 *buffer_address = NULL;
3916 } 3917 }
3917 3918
3918 3919
3919 } } // namespace v8::internal 3920 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/lithium.cc ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698