Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 12090078: Media Galleries: Update tooltips in permission dialogs when galleries change. (Closed)

Created:
7 years, 10 months ago by Lei Zhang
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Media Galleries: Update tooltips in permission dialogs when galleries change. TEST=In the media gallery permission dialog, hover over the gallery entry for a USB drive and see a path. Unplug the device and hover over the now detached gallery should no longer show a tooltip. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180049

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
7 years, 10 months ago (2013-01-30 22:44:33 UTC) #1
Lei Zhang
I should mention, the Mac version already does this.
7 years, 10 months ago (2013-01-30 22:44:58 UTC) #2
Lei Zhang
Greg, can you review this? I figured you probably read all this code recently so ...
7 years, 10 months ago (2013-01-31 22:58:58 UTC) #3
Greg Billock
lgtm https://chromiumcodereview.appspot.com/12090078/diff/1/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc File chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc (right): https://chromiumcodereview.appspot.com/12090078/diff/1/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc#newcode112 chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc:112: MediaGalleriesDialogController::GetGalleryTooltip(*gallery); Good. I did this in my change ...
7 years, 10 months ago (2013-01-31 23:01:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12090078/1
7 years, 10 months ago (2013-01-31 23:17:47 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 03:02:36 UTC) #6
Message was sent while issue was closed.
Change committed as 180049

Powered by Google App Engine
This is Rietveld 408576698