Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3108)

Unified Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc

Issue 12090078: Media Galleries: Update tooltips in permission dialogs when galleries change. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
===================================================================
--- chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc (revision 179687)
+++ chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc (working copy)
@@ -108,18 +108,20 @@
bool permitted) {
string16 label =
MediaGalleriesDialogController::GetGalleryDisplayName(*gallery);
+ string16 tooltip_text =
+ MediaGalleriesDialogController::GetGalleryTooltip(*gallery);
Greg Billock 2013/01/31 23:01:21 Good. I did this in my change as well. It'll merge
CheckboxMap::iterator iter = checkbox_map_.find(gallery);
if (iter != checkbox_map_.end()) {
views::Checkbox* checkbox = iter->second;
checkbox->SetChecked(permitted);
checkbox->SetText(label);
+ checkbox->SetTooltipText(tooltip_text);
return false;
}
views::Checkbox* checkbox = new views::Checkbox(label);
checkbox->set_listener(this);
- checkbox->SetTooltipText(
- MediaGalleriesDialogController::GetGalleryTooltip(*gallery));
+ checkbox->SetTooltipText(tooltip_text);
checkbox_container_->AddChildView(checkbox);
checkbox->SetChecked(permitted);
checkbox_map_[gallery] = checkbox;
« no previous file with comments | « chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698