Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 12090015: Implement CreateDirectoryOperation on Drive API v2. (Closed)

Created:
7 years, 10 months ago by hidehiko
Modified:
7 years, 10 months ago
Reviewers:
satorux1, kinaba
CC:
chromium-reviews, stevenjb+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement CreateDirectoryOperation on Drive API v2. By this CL, now the DriveAPIService supports create directory operation. BUG=148629 TEST=Ran unittest. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179600

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add an empty line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -2 lines) Patch
M chrome/browser/google_apis/drive_api_operations.h View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations.cc View 1 2 chunks +63 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 1 chunk +8 lines, -2 lines 0 comments Download
A chrome/test/data/chromeos/drive/directory_entry.json View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 10 months ago (2013-01-28 08:59:20 UTC) #1
kinaba
lgtm
7 years, 10 months ago (2013-01-28 11:20:50 UTC) #2
satorux1
LGTM with a nit https://codereview.chromium.org/12090015/diff/2001/chrome/browser/google_apis/drive_api_operations.cc File chrome/browser/google_apis/drive_api_operations.cc (right): https://codereview.chromium.org/12090015/diff/2001/chrome/browser/google_apis/drive_api_operations.cc#newcode120 chrome/browser/google_apis/drive_api_operations.cc:120: //========================== CreateDirectoryOperation ========================== nit: add ...
7 years, 10 months ago (2013-01-29 04:51:41 UTC) #3
hidehiko
Thank you for your review. Committing. https://codereview.chromium.org/12090015/diff/2001/chrome/browser/google_apis/drive_api_operations.cc File chrome/browser/google_apis/drive_api_operations.cc (right): https://codereview.chromium.org/12090015/diff/2001/chrome/browser/google_apis/drive_api_operations.cc#newcode120 chrome/browser/google_apis/drive_api_operations.cc:120: //========================== CreateDirectoryOperation ========================== ...
7 years, 10 months ago (2013-01-29 05:40:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12090015/3004
7 years, 10 months ago (2013-01-29 05:41:00 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 05:59:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12090015/3004
7 years, 10 months ago (2013-01-29 07:10:44 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 07:25:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12090015/3004
7 years, 10 months ago (2013-01-29 13:24:18 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 13:44:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12090015/3004
7 years, 10 months ago (2013-01-29 13:55:16 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 14:31:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12090015/3004
7 years, 10 months ago (2013-01-30 02:58:19 UTC) #13
commit-bot: I haz the power
7 years, 10 months ago (2013-01-30 11:49:46 UTC) #14
Message was sent while issue was closed.
Change committed as 179600

Powered by Google App Engine
This is Rietveld 408576698