Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 12087078: Add unit tests for nonuniform GPU memmgr policy (Closed)

Created:
7 years, 10 months ago by ccameron
Modified:
7 years, 10 months ago
Reviewers:
nduca, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Add unit tests for nonuniform GPU memmgr policy. Add a default memory allocation level for clients that have not yet sent memory usage levels to the manager. This default is currently set to equal the minimum, but the minimum will be lowered substantially in the future (and the default will stay higher, to avoid a low-res flicker at load). Change GetMinimumClientAllocation to always use a value set during initialization instead of having a separate override flag. Fix a comparison bug that caused no clients to retain their memory when made nonvisible. Make clients that are nonvisible and have had their memory evicted not be given a budget that gives them back their memory until they are made visible again. This prevents situations where we burn resources painting-then-freeing resources for backgrounded clients. BUG=168413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180054

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Clean up private #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -19 lines) Patch
M content/common/gpu/gpu_memory_manager.h View 1 2 5 chunks +27 lines, -5 lines 1 comment Download
M content/common/gpu/gpu_memory_manager.cc View 1 8 chunks +31 lines, -14 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 1 2 3 chunks +176 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ccameron
After this I won't be too afraid of switching the memmgr over to the impl-side ...
7 years, 10 months ago (2013-01-30 03:10:41 UTC) #1
ccameron
https://codereview.chromium.org/12087078/diff/7/content/common/gpu/gpu_memory_manager.h File content/common/gpu/gpu_memory_manager.h (right): https://codereview.chromium.org/12087078/diff/7/content/common/gpu/gpu_memory_manager.h#newcode105 content/common/gpu/gpu_memory_manager.h:105: DefaultAllocation); This list is getting fairly absurdly long. There ...
7 years, 10 months ago (2013-01-30 21:03:19 UTC) #2
ccameron
Ping.
7 years, 10 months ago (2013-01-31 18:13:49 UTC) #3
nduca
lgtm
7 years, 10 months ago (2013-01-31 19:48:59 UTC) #4
ccameron
Thanks! piman, can you do an OWNER review?
7 years, 10 months ago (2013-01-31 22:55:39 UTC) #5
piman
lgtm
7 years, 10 months ago (2013-01-31 23:10:17 UTC) #6
ccameron
Thanks!!
7 years, 10 months ago (2013-01-31 23:50:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/12087078/7
7 years, 10 months ago (2013-02-01 00:23:47 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 03:19:08 UTC) #9
Message was sent while issue was closed.
Change committed as 180054

Powered by Google App Engine
This is Rietveld 408576698