Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12084088: Renamed WebMediaStreamComponent and WebMediaStreamDescriptor to WebMediaStreamTrack & WebMediaStream (Closed)

Created:
7 years, 10 months ago by Tommy Widenflycht
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Renamed WebMediaStreamComponent and WebMediaStreamDescriptor to WebMediaStreamTrack & WebMediaStream Depends on a not yet landed WebKit patch BUG=173105 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -171 lines) Patch
M content/renderer/media/media_stream_center.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/media_stream_center.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.h View 3 chunks +5 lines, -12 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory_unittest.cc View 6 chunks +11 lines, -12 lines 0 comments Download
M content/renderer/media/media_stream_extra_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 3 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 6 chunks +12 lines, -16 lines 0 comments Download
M content/renderer/media/mock_web_rtc_peer_connection_handler_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/peer_connection_handler_base.h View 3 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/media/peer_connection_handler_base.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 5 chunks +20 lines, -20 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 10 chunks +17 lines, -17 lines 0 comments Download
M webkit/support/test_media_stream_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Tommy Widenflycht
7 years, 10 months ago (2013-01-31 13:15:27 UTC) #1
Tommy Widenflycht
tkent@ : I need your approval for webkit/support/test_media_stream_client.cc
7 years, 10 months ago (2013-01-31 13:16:59 UTC) #2
Tommy Widenflycht
7 years, 10 months ago (2013-01-31 13:17:18 UTC) #3
tkent
LGTM for webkit/support/.
7 years, 10 months ago (2013-01-31 13:18:39 UTC) #4
tommi (sloooow) - chröme
lgtm
7 years, 10 months ago (2013-01-31 13:24:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/12084088/1
7 years, 10 months ago (2013-02-01 08:55:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/12084088/1
7 years, 10 months ago (2013-02-01 10:11:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/12084088/1
7 years, 10 months ago (2013-02-01 12:39:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/12084088/1
7 years, 10 months ago (2013-02-01 16:41:24 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 10 months ago (2013-02-01 17:46:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/12084088/1
7 years, 10 months ago (2013-02-04 08:17:53 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-02-04 12:07:19 UTC) #12
Message was sent while issue was closed. 
Change committed as 180389

Powered by Google App Engine
This is Rietveld 408576698