SavePackageFilePickerChromeOS should only force MHTML when saving HTML, not when saving text/image/…

SavePackageFilePickerChromeOS should only force MHTML when saving HTML, not when saving text/image/etc.
BUG=166595
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185747

[benjhayden, 2013-02-06 21:46:49]

PTAL

[Randy Smith (Not in Mondays), 2013-02-07 21:18:55]

So there are two things that bother me about this code:

* can_save_as_complete is used as a proxy for "Is HTML?"
* SAVE_AS_ONLY_HTML really means "Save in natural, non-combined format dependent
on mime type"

The first one we can mitigate by calling the parameter is_html in the file
picker arguments and member variables; can you do that?

The second was there already and I won't make you change it as part of this CL,
but it would be nice if we could clean it up at some point.

Other than that, LGTM.

[achuithb, 2013-02-08 23:41:14]

lgtm

[benjhayden, 2013-03-01 21:35:28]

On 2013/02/08 23:41:14, achuith.bhandarkar wrote:
> lgtm

Finally renamed can_save_as_complete to is_html in
save_package_file_picker_chromeos.
Committing.
Thanks!

[commit-bot: I haz the power, 2013-03-01 21:40:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/12084075/46001

[commit-bot: I haz the power, 2013-03-02 16:03:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/12084075/57005

[commit-bot: I haz the power, 2013-03-02 18:50:58]

Change committed as 185747