Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6386)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 12084075: SavePackageFilePickerChromeOS should only force MHTML when saving HTML, not when saving text/image/… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: @r185696 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index f7e73feaf2069f9a60e93e599e38c99b9725f21a..110e2c8301f1a6d68e04de2071116b1c98bf5fc6 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -778,5 +778,29 @@ IN_PROC_BROWSER_TEST_F(SavePageAsMHTMLBrowserTest, SavePageAsMHTML) {
EXPECT_LE(kFileSizeMin, actual_file_size);
}
+IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, SavePageBrowserTest_NonMHTML) {
+#if defined(OS_CHROMEOS)
+ SavePackageFilePickerChromeOS::SetShouldPromptUser(false);
+#else
+ SavePackageFilePicker::SetShouldPromptUser(false);
+#endif
+ GURL url("data:text/plain,foo");
+ ui_test_utils::NavigateToURL(browser(), url);
+ scoped_refptr<content::MessageLoopRunner> loop_runner(
+ new content::MessageLoopRunner);
+ SavePackageFinishedObserver observer(
+ content::BrowserContext::GetDownloadManager(browser()->profile()),
+ loop_runner->QuitClosure());
+ chrome::SavePage(browser());
+ loop_runner->Run();
+ base::FilePath download_dir = DownloadPrefs::FromDownloadManager(
+ GetDownloadManager())->DownloadPath();
+ base::FilePath filename = download_dir.AppendASCII("dataurl.txt");
+ EXPECT_TRUE(file_util::PathExists(filename));
+ std::string contents;
+ EXPECT_TRUE(file_util::ReadFileToString(filename, &contents));
+ EXPECT_EQ("foo", contents);
+}
+
} // namespace
« no previous file with comments | « chrome/browser/download/save_package_file_picker_chromeos.cc ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698