Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 12082091: [telemetry] Add TraceResult as return value from tracing, and placeholder trace_event_importer. (Closed)

Created:
7 years, 10 months ago by nduca
Modified:
7 years, 10 months ago
Reviewers:
marja
CC:
chromium-reviews, chrome-speed-team+watch_google.com, tfarina, telemetry+watch_chromium.org, dtu, tonyg
Visibility:
Public.

Description

[telemetry] Add TraceResult as return value from tracing, and placeholder trace_event_importer. This is infrastructure for adding trace_event parsing to telemetry. BUG=173327 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179843

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -17 lines) Patch
M tools/telemetry/telemetry/browser.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page_runner.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/run_tests.py View 1 chunk +0 lines, -6 lines 0 comments Download
A tools/telemetry/telemetry/trace_event_importer.py View 1 chunk +15 lines, -0 lines 1 comment Download
A tools/telemetry/telemetry/trace_result.py View 1 1 chunk +16 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/tracing_backend.py View 1 3 chunks +33 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/tracing_backend_unittest.py View 1 2 chunks +43 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nduca
Tracing previously returned a string formatted as a chrome trace. We try to keep core ...
7 years, 10 months ago (2013-01-31 09:29:25 UTC) #1
nduca
7 years, 10 months ago (2013-01-31 09:29:50 UTC) #2
marja
lgtm with nits: https://codereview.chromium.org/12082091/diff/1/tools/telemetry/telemetry/tracing_backend.py File tools/telemetry/telemetry/tracing_backend.py (right): https://codereview.chromium.org/12082091/diff/1/tools/telemetry/telemetry/tracing_backend.py#newcode25 tools/telemetry/telemetry/tracing_backend.py:25: def WriteToFile(self, f): As it's not ...
7 years, 10 months ago (2013-01-31 09:41:48 UTC) #3
nduca
ty, nits fixed
7 years, 10 months ago (2013-01-31 09:47:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12082091/5001
7 years, 10 months ago (2013-01-31 09:50:22 UTC) #5
marja
https://codereview.chromium.org/12082091/diff/5001/tools/telemetry/telemetry/trace_event_importer.py File tools/telemetry/telemetry/trace_event_importer.py (right): https://codereview.chromium.org/12082091/diff/5001/tools/telemetry/telemetry/trace_event_importer.py#newcode9 tools/telemetry/telemetry/trace_event_importer.py:9: def Import(data): Hmm, we still convert an array of ...
7 years, 10 months ago (2013-01-31 09:51:06 UTC) #6
nduca
Not a bad idea. I'll see what I can do on my followup patch, maybe ...
7 years, 10 months ago (2013-01-31 10:10:59 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 10:24:10 UTC) #8
Message was sent while issue was closed.
Change committed as 179843

Powered by Google App Engine
This is Rietveld 408576698