tools/telemetry/telemetry/page_runner.py - Issue 12082091: [telemetry] Add TraceResult as return value from tracing, and placeholder trace_event_importer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page_runner.py

Issue 12082091: [telemetry] Add TraceResult as return value from tracing, and placeholder trace_event_importer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/browser_backend.py ('k') | tools/telemetry/telemetry/run_tests.py » ('j') | tools/telemetry/telemetry/trace_event_importer.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page_runner.py

diff --git a/tools/telemetry/telemetry/page_runner.py b/tools/telemetry/telemetry/page_runner.py

index 0cecf2aae04f03757f28d9862fa2cf4a4ab1ef53..ae1939823f87af6b8f7b45a1ad502d2bc36bf70f 100644

--- a/tools/telemetry/telemetry/page_runner.py

+++ b/tools/telemetry/telemetry/page_runner.py

@@ -248,7 +248,7 @@ class PageRunner(object):

assert state.browser

state.is_tracing = False

state.browser.StopTracing()

- trace = state.browser.GetTrace()

+ trace_result = state.browser.GetTraceResultAndReset()

logging.info('Processing trace...')

trace_file_base = os.path.join(

@@ -266,7 +266,7 @@ class PageRunner(object):

trace_file = '%s.json' % trace_file_base

with codecs.open(trace_file, 'w',

encoding='utf-8') as trace_file:

- trace_file.write(trace)

+ trace_result.WriteToFile(trace_file)

logging.info('Trace saved.')

def _PreparePage(self, page, tab, page_state, test, results):