Issue 12079061: Sends the scroll gesture to scrollbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12079061: Sends the scroll gesture to scrollbar. (Closed)

Created:
7 years, 10 months ago by Jun Mukai

Modified:
7 years, 10 months ago

Reviewers:
miket_OOO, dharcourt

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Sends the scroll gesture to scrollbar. Noticed that SlideOutView calls handled() to any scroll gestures, even though the gesture doesn't have very litle (or no) effects horizontally. So normal vertical scroll gestures will be ignored if the gesture event happens on the cards. BUG=172991 TEST=on device, open with many notifications and scroll it by gesture Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180042

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	ui/message_center/message_view.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12079061/1

7 years, 10 months ago (2013-01-31 23:16:47 UTC) #4

Message was sent while issue was closed.

Change committed as 180042

Expand Messages | Collapse Messages