Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: ui/message_center/message_view.cc

Issue 12079061: Sends the scroll gesture to scrollbar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_view.cc
diff --git a/ui/message_center/message_view.cc b/ui/message_center/message_view.cc
index 7618ec05ecb6cb8bf00458341dbb3de38ccd1ac0..56d3a3b46a4d15d9cb92e2b20c258731763a2ad0 100644
--- a/ui/message_center/message_view.cc
+++ b/ui/message_center/message_view.cc
@@ -264,8 +264,9 @@ void MessageView::OnGestureEvent(ui::GestureEvent* event) {
}
SlideOutView::OnGestureEvent(event);
- if (event->handled())
- return;
+ // Do not return here by checking handled(). SlideOutView calls SetHandled()
+ // even though the scroll gesture doesn't make no (or little) effects on the
+ // slide-out behavior. See http://crbug.com/172991
if (!event->IsScrollGestureEvent())
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698