Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 12079026: ipc: Do not use Value::Create* functions. (Closed)

Created:
7 years, 10 months ago by tfarina
Modified:
7 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M ipc/ipc_message_unittest.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
7 years, 10 months ago (2013-01-28 15:42:14 UTC) #1
tfarina
Hi Carlos, could you approve this trivial patch? Thanks,
7 years, 10 months ago (2013-01-29 16:02:15 UTC) #2
darin (slow to review)
LGTM (sorry for the delay!)
7 years, 10 months ago (2013-01-29 22:26:09 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm sorry I was out of office
7 years, 10 months ago (2013-01-30 00:10:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12079026/1
7 years, 10 months ago (2013-01-30 00:13:59 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-01-30 05:24:09 UTC) #6
Message was sent while issue was closed.
Change committed as 179538

Powered by Google App Engine
This is Rietveld 408576698