Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: ipc/ipc_message_unittest.cc

Issue 12079026: ipc: Do not use Value::Create* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/ipc_message_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_unittest.cc
diff --git a/ipc/ipc_message_unittest.cc b/ipc/ipc_message_unittest.cc
index 4c0d514f68a1220c7694a01c7ced988ec2dad14f..6a40acd5f824d6191d2ad9c61be73ed184e8858d 100644
--- a/ipc/ipc_message_unittest.cc
+++ b/ipc/ipc_message_unittest.cc
@@ -15,9 +15,9 @@ namespace {
TEST(IPCMessageTest, ListValue) {
ListValue input;
- input.Set(0, Value::CreateDoubleValue(42.42));
- input.Set(1, Value::CreateStringValue("forty"));
- input.Set(2, Value::CreateNullValue());
+ input.Set(0, new base::FundamentalValue(42.42));
+ input.Set(1, new base::StringValue("forty"));
+ input.Set(2, base::Value::CreateNullValue());
IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
IPC::WriteParam(&msg, input);
@@ -38,18 +38,18 @@ TEST(IPCMessageTest, ListValue) {
TEST(IPCMessageTest, DictionaryValue) {
DictionaryValue input;
input.Set("null", Value::CreateNullValue());
- input.Set("bool", Value::CreateBooleanValue(true));
- input.Set("int", Value::CreateIntegerValue(42));
- input.SetWithoutPathExpansion("int.with.dot", Value::CreateIntegerValue(43));
+ input.Set("bool", new base::FundamentalValue(true));
+ input.Set("int", new base::FundamentalValue(42));
+ input.SetWithoutPathExpansion("int.with.dot", new base::FundamentalValue(43));
scoped_ptr<DictionaryValue> subdict(new DictionaryValue());
- subdict->Set("str", Value::CreateStringValue("forty two"));
- subdict->Set("bool", Value::CreateBooleanValue(false));
+ subdict->Set("str", new base::StringValue("forty two"));
+ subdict->Set("bool", new base::FundamentalValue(false));
scoped_ptr<ListValue> sublist(new ListValue());
- sublist->Set(0, Value::CreateDoubleValue(42.42));
- sublist->Set(1, Value::CreateStringValue("forty"));
- sublist->Set(2, Value::CreateStringValue("two"));
+ sublist->Set(0, new base::FundamentalValue(42.42));
+ sublist->Set(1, new base::StringValue("forty"));
+ sublist->Set(2, new base::StringValue("two"));
subdict->Set("list", sublist.release());
input.Set("dict", subdict.release());
« no previous file with comments | « no previous file | ipc/ipc_message_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698