Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12069004: google_apis: Move AppendQueryParameter() etc. from common/net/url_util.h to net/base/url_util.h (Closed)

Created:
7 years, 10 months ago by tfarina
Modified:
7 years, 10 months ago
Reviewers:
satorux1, mmenke
CC:
chromium-reviews, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, Albert Bodenhamer, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, benquan, rouslan+watch_chromium.org, achuith+watch_chromium.org, dbeam+watch-autofill_chromium.org, darin-cc_chromium.org, gbillock+watch_chromium.org, chromium-apps-reviews_chromium.org, groby+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, smckay+watch_chromium.org, Raman Kakilate, Ilya Sherman, Aaron Boodman, Dane Wallinga, dyu1, estade+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

google_apis: Move AppendQueryParameter() etc. from common/net/url_util.h to net/base/url_util.h Which removes one more dependency on chrome/common/ BUG=146989 TEST=net_unittests --gtest_filter=UrlUtilTest* R=satorux@chromium.org,mmenke@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179902

Patch Set 1 : #

Total comments: 4

Patch Set 2 : move GetValueForKeyInQuery to net/base/url_util.h too #

Patch Set 3 : rm unused includes of chrome/common/net/url_util.h #

Patch Set 4 : unnamed namespace #

Total comments: 3

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -372 lines) Patch
M chrome/browser/autofill/wallet/wallet_service_url.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google/google_util.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google_apis/drive_api_url_generator.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/gdata_contacts_operations.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/gdata_wapi_url_generator.cc View 1 2 3 4 3 chunks +11 lines, -18 lines 0 comments Download
M chrome/browser/intents/cws_intents_registry.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 5 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/web_resource/notification_promo.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/net/url_util.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/common/net/url_util.cc View 1 2 chunks +0 lines, -86 lines 0 comments Download
M chrome/common/net/url_util_unittest.cc View 1 1 chunk +0 lines, -102 lines 0 comments Download
A + net/base/url_util.h View 1 3 chunks +17 lines, -24 lines 0 comments Download
A + net/base/url_util.cc View 1 5 chunks +13 lines, -35 lines 0 comments Download
A + net/base/url_util_unittest.cc View 1 2 3 3 chunks +7 lines, -5 lines 0 comments Download
M net/net.gyp View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
Please, take a look. Thanks,
7 years, 10 months ago (2013-01-28 14:48:55 UTC) #1
mmenke
https://codereview.chromium.org/12069004/diff/7001/chrome/common/net/url_util.h File chrome/common/net/url_util.h (right): https://codereview.chromium.org/12069004/diff/7001/chrome/common/net/url_util.h#newcode28 chrome/common/net/url_util.h:28: std::string* out_value); Think we should move this, too. It's ...
7 years, 10 months ago (2013-01-28 15:33:36 UTC) #2
tfarina
https://codereview.chromium.org/12069004/diff/7001/chrome/common/net/url_util.h File chrome/common/net/url_util.h (right): https://codereview.chromium.org/12069004/diff/7001/chrome/common/net/url_util.h#newcode28 chrome/common/net/url_util.h:28: std::string* out_value); On 2013/01/28 15:33:37, Matt Menke wrote: > ...
7 years, 10 months ago (2013-01-28 15:55:57 UTC) #3
mmenke
LGTM https://codereview.chromium.org/12069004/diff/11001/net/base/url_util.cc File net/base/url_util.cc (right): https://codereview.chromium.org/12069004/diff/11001/net/base/url_util.cc#newcode86 net/base/url_util.cc:86: UnescapeRule::REPLACE_PLUS_WITH_SPACE); Did you deliberately reduce the indent here?
7 years, 10 months ago (2013-01-28 16:01:01 UTC) #4
tfarina
https://codereview.chromium.org/12069004/diff/11001/net/base/url_util.cc File net/base/url_util.cc (right): https://codereview.chromium.org/12069004/diff/11001/net/base/url_util.cc#newcode86 net/base/url_util.cc:86: UnescapeRule::REPLACE_PLUS_WITH_SPACE); On 2013/01/28 16:01:02, Matt Menke wrote: > Did ...
7 years, 10 months ago (2013-01-28 16:04:10 UTC) #5
mmenke
https://codereview.chromium.org/12069004/diff/11001/net/base/url_util.cc File net/base/url_util.cc (right): https://codereview.chromium.org/12069004/diff/11001/net/base/url_util.cc#newcode86 net/base/url_util.cc:86: UnescapeRule::REPLACE_PLUS_WITH_SPACE); On 2013/01/28 16:04:10, tfarina wrote: > On 2013/01/28 ...
7 years, 10 months ago (2013-01-28 16:05:34 UTC) #6
satorux1
chrome/browser/google_apis LGTM. Thank you for doing this. I think the description is rather misleading. I'd ...
7 years, 10 months ago (2013-01-29 04:48:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12069004/12032
7 years, 10 months ago (2013-01-31 15:00:35 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 17:41:06 UTC) #9
Message was sent while issue was closed. 
Change committed as 179902

Powered by Google App Engine
This is Rietveld 408576698