Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: chrome/browser/ui/chrome_pages.cc

Issue 12069004: google_apis: Move AppendQueryParameter() etc. from common/net/url_util.h to net/base/url_util.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/chrome_pages.h" 5 #include "chrome/browser/ui/chrome_pages.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/string_number_conversions.h" 8 #include "base/string_number_conversions.h"
9 #include "base/stringprintf.h" 9 #include "base/stringprintf.h"
10 #include "chrome/browser/download/download_shelf.h" 10 #include "chrome/browser/download/download_shelf.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/sync/profile_sync_service.h" 12 #include "chrome/browser/sync/profile_sync_service.h"
13 #include "chrome/browser/sync/profile_sync_service_factory.h" 13 #include "chrome/browser/sync/profile_sync_service_factory.h"
14 #include "chrome/browser/ui/browser.h" 14 #include "chrome/browser/ui/browser.h"
15 #include "chrome/browser/ui/browser_finder.h" 15 #include "chrome/browser/ui/browser_finder.h"
16 #include "chrome/browser/ui/browser_navigator.h" 16 #include "chrome/browser/ui/browser_navigator.h"
17 #include "chrome/browser/ui/browser_window.h" 17 #include "chrome/browser/ui/browser_window.h"
18 #include "chrome/browser/ui/singleton_tabs.h" 18 #include "chrome/browser/ui/singleton_tabs.h"
19 #include "chrome/browser/ui/tabs/tab_strip_model.h" 19 #include "chrome/browser/ui/tabs/tab_strip_model.h"
20 #include "chrome/browser/ui/webui/options/content_settings_handler.h" 20 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
21 #include "chrome/browser/ui/webui/signin/login_ui_service.h" 21 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
22 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h" 22 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
23 #include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h" 23 #include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"
24 #include "chrome/common/net/url_util.h"
25 #include "chrome/common/url_constants.h" 24 #include "chrome/common/url_constants.h"
26 #include "content/public/browser/user_metrics.h" 25 #include "content/public/browser/user_metrics.h"
27 #include "google_apis/gaia/gaia_urls.h" 26 #include "google_apis/gaia/gaia_urls.h"
28 #include "googleurl/src/gurl.h" 27 #include "googleurl/src/gurl.h"
28 #include "net/base/url_util.h"
29 29
30 using content::UserMetricsAction; 30 using content::UserMetricsAction;
31 31
32 namespace chrome { 32 namespace chrome {
33 namespace { 33 namespace {
34 34
35 const char kHashMark[] = "#"; 35 const char kHashMark[] = "#";
36 36
37 void OpenBookmarkManagerWithHash(Browser* browser, 37 void OpenBookmarkManagerWithHash(Browser* browser,
38 const std::string& action, 38 const std::string& action,
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 } 219 }
220 220
221 DCHECK_GT(browser->tab_strip_model()->count(), 0); 221 DCHECK_GT(browser->tab_strip_model()->count(), 0);
222 } 222 }
223 } 223 }
224 224
225 void ShowGaiaSignin(Browser* browser, 225 void ShowGaiaSignin(Browser* browser,
226 const std::string& service, 226 const std::string& service,
227 const GURL& continue_url) { 227 const GURL& continue_url) {
228 GURL url(GaiaUrls::GetInstance()->service_login_url()); 228 GURL url(GaiaUrls::GetInstance()->service_login_url());
229 url = chrome_common_net::AppendQueryParameter(url, "service", service); 229 url = net::AppendQueryParameter(url, "service", service);
230 if (continue_url.is_valid()) 230 if (continue_url.is_valid())
231 url = chrome_common_net::AppendQueryParameter(url, 231 url = net::AppendQueryParameter(url, "continue", continue_url.spec());
232 "continue",
233 continue_url.spec());
234 NavigateToSingletonTab(browser, url); 232 NavigateToSingletonTab(browser, url);
235 } 233 }
236 234
237 } // namespace chrome 235 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/net/gaia/gaia_oauth_fetcher.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698