Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 12052053: Add StubFailureTrampolineFrames (Closed)

Created:
7 years, 11 months ago by danno
Modified:
7 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add StubFailureTrampolineFrames In preparation of supporting stubs that deopt and then need to push their register-based parameters to an arguments area on the stack that gets properly collected, add StubFailureTrampolineFrames to hold those parameters. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13533

Patch Set 1 #

Patch Set 2 : Improve comments #

Patch Set 3 : Better comments again #

Patch Set 4 : Handle saving floating point registers correctly #

Patch Set 5 : Remove extraneous change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -144 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 2 3 2 chunks +58 lines, -36 lines 0 comments Download
M src/code-stubs.h View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/frames.h View 1 2 3 3 chunks +29 lines, -10 lines 0 comments Download
M src/frames.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/frames-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 2 3 2 chunks +58 lines, -38 lines 0 comments Download
M src/ic.cc View 1 chunk +6 lines, -21 lines 0 comments Download
M src/isolate.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 2 3 2 chunks +57 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
Please take a look
7 years, 11 months ago (2013-01-24 13:06:10 UTC) #1
Sven Panne
7 years, 10 months ago (2013-01-28 13:26:57 UTC) #2
LGTM if tests for deopting with the new frame type are added in future CLs (as
discussed offline).

Powered by Google App Engine
This is Rietveld 408576698