Index: src/ia32/deoptimizer-ia32.cc |
diff --git a/src/ia32/deoptimizer-ia32.cc b/src/ia32/deoptimizer-ia32.cc |
index 029dbfbe29b31a19ded56260220a8e339dbadd06..8da0739b9630288139c89cacb48639cb58efe112 100644 |
--- a/src/ia32/deoptimizer-ia32.cc |
+++ b/src/ia32/deoptimizer-ia32.cc |
@@ -562,22 +562,27 @@ void Deoptimizer::DoComputeArgumentsAdaptorFrame(TranslationIterator* iterator, |
void Deoptimizer::DoCompiledStubFrame(TranslationIterator* iterator, |
int frame_index) { |
// |
- // FROM TO <-ebp |
+ // FROM TO |
// | .... | | .... | |
// +-------------------------+ +-------------------------+ |
- // | JSFunction continuation | | parameter 1 | |
+ // | JSFunction continuation | | JSFunction continuation | |
// +-------------------------+ +-------------------------+ |
- // | | saved frame (ebp) | | .... | |
- // | +=========================+<-ebp +-------------------------+ |
- // | | JSFunction context | | parameter n | |
+ // | | saved frame (ebp) | | saved frame (ebp) | |
+ // | +=========================+<-ebp +=========================+<-ebp |
+ // | | JSFunction context | | JSFunction context | |
// v +-------------------------+ +-------------------------| |
- // | COMPILED_STUB marker | | JSFunction continuation | |
- // +-------------------------+ +-------------------------+<-esp |
- // | | eax = number of parameters |
- // | ... | ebx = failure handler address |
- // | | ebp = saved frame |
- // +-------------------------+<-esp esi = JSFunction context |
- // |
+ // | COMPILED_STUB marker | | STUB_FAILURE marker | |
+ // +-------------------------+ +-------------------------+ |
+ // | | | stub parameter 1 | |
+ // | ... | +-------------------------+ |
+ // | | | ... | |
+ // |-------------------------|<-esp +-------------------------+ |
+ // | stub parameter n | |
+ // parameters in registers +-------------------------+<-esp |
+ // and spilled to stack eax = number of parameters |
+ // ebx = failure handler address |
+ // ebp = saved frame |
+ // esi = JSFunction context |
// |
ASSERT(compiled_code_->kind() == Code::COMPILED_STUB); |
@@ -585,49 +590,64 @@ void Deoptimizer::DoCompiledStubFrame(TranslationIterator* iterator, |
CodeStubInterfaceDescriptor* descriptor = |
isolate_->code_stub_interface_descriptor(major_key); |
- int output_frame_size = |
- (1 + descriptor->register_param_count_) * kPointerSize; |
+ int output_frame_size = StandardFrameConstants::kFixedFrameSize + |
+ kPointerSize * descriptor->register_param_count_; |
+ |
FrameDescription* output_frame = |
new(output_frame_size) FrameDescription(output_frame_size, 0); |
+ ASSERT(frame_index == 0); |
+ output_[frame_index] = output_frame; |
Code* notify_failure = |
isolate_->builtins()->builtin(Builtins::kNotifyStubFailure); |
output_frame->SetState(Smi::FromInt(FullCodeGenerator::NO_REGISTERS)); |
output_frame->SetContinuation( |
- reinterpret_cast<uint32_t>(notify_failure->entry())); |
+ reinterpret_cast<intptr_t>(notify_failure->entry())); |
- Code* code; |
- SaveFPRegsMode mode = |
- CpuFeatures::IsSupported(SSE2) ? kSaveFPRegs : kDontSaveFPRegs; |
- CEntryStub(1, mode).FindCodeInCache(&code, isolate_); |
- output_frame->SetPc(reinterpret_cast<intptr_t>(code->instruction_start())); |
+ Code* trampoline = NULL; |
+ StubFailureTrampolineStub().FindCodeInCache(&trampoline, isolate_); |
+ ASSERT(trampoline != NULL); |
+ output_frame->SetPc(reinterpret_cast<intptr_t>( |
+ trampoline->instruction_start())); |
unsigned input_frame_size = input_->GetFrameSize(); |
- intptr_t value = input_->GetFrameSlot(input_frame_size - kPointerSize); |
- output_frame->SetFrameSlot(0, value); |
- value = input_->GetFrameSlot(input_frame_size - 2 * kPointerSize); |
- output_frame->SetRegister(ebp.code(), value); |
- output_frame->SetFp(value); |
- value = input_->GetFrameSlot(input_frame_size - 3 * kPointerSize); |
+ |
+ // JSFunction continuation |
+ intptr_t input_frame_offset = input_frame_size - kPointerSize; |
+ intptr_t output_frame_offset = output_frame_size - kPointerSize; |
+ intptr_t value = input_->GetFrameSlot(input_frame_offset); |
+ output_frame->SetFrameSlot(output_frame_offset, value); |
+ |
+ // saved frame ptr |
+ input_frame_offset -= kPointerSize; |
+ value = input_->GetFrameSlot(input_frame_offset); |
+ output_frame_offset -= kPointerSize; |
+ output_frame->SetFrameSlot(output_frame_offset, value); |
+ |
+ // Restore context |
+ input_frame_offset -= kPointerSize; |
+ value = input_->GetFrameSlot(input_frame_offset); |
output_frame->SetRegister(esi.code(), value); |
+ output_frame_offset -= kPointerSize; |
+ output_frame->SetFrameSlot(output_frame_offset, value); |
+ |
+ // Internal frame markers |
+ output_frame_offset -= kPointerSize; |
+ value = reinterpret_cast<intptr_t>( |
+ Smi::FromInt(StackFrame::STUB_FAILURE_TRAMPOLINE)); |
+ output_frame->SetFrameSlot(output_frame_offset, value); |
- int parameter_offset = kPointerSize * descriptor->register_param_count_; |
for (int i = 0; i < descriptor->register_param_count_; ++i) { |
- Translation::Opcode opcode = |
- static_cast<Translation::Opcode>(iterator->Next()); |
- ASSERT(opcode == Translation::REGISTER); |
- USE(opcode); |
- int input_reg = iterator->Next(); |
- intptr_t reg_value = input_->GetRegister(input_reg); |
- output_frame->SetFrameSlot(parameter_offset, reg_value); |
- parameter_offset -= kPointerSize; |
+ output_frame_offset -= kPointerSize; |
+ DoTranslateCommand(iterator, 0, output_frame_offset); |
} |
+ value = input_->GetRegister(ebp.code()); |
+ output_frame->SetRegister(ebp.code(), value); |
+ output_frame->SetFp(value); |
+ |
intptr_t handler = |
reinterpret_cast<intptr_t>(descriptor->deoptimization_handler_); |
output_frame->SetRegister(eax.code(), descriptor->register_param_count_); |
output_frame->SetRegister(ebx.code(), handler); |
- |
- ASSERT(frame_index == 0); |
- output_[frame_index] = output_frame; |
} |