Switch to Cocoa APIs for fullscreen.

Switch to Cocoa APIs for fullscreen.

BUG=170189
TEST=no change


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178470

[Avi (use Gerrit), 2013-01-22 16:18:20]

Nico for review, Mark FYI.

In Carbon, to get the global ui mode you had to listen to notifications. In
Cocoa... you just ask NSApp. So this means we can get rid of a bit of code at
startup time. I doubt it will have a real impact on Ts, but it shouldn't regress
it.

The fullscreen_mac code changed from
https://chromiumcodereview.appspot.com/11697004/ but the rest is the same.

[Nico, 2013-01-23 21:35:21]

Lots of red code, nice!

https://codereview.chromium.org/12052012/diff/1/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

https://codereview.chromium.org/12052012/diff/1/base/mac/mac_util.mm#newcode54
base/mac/mac_util.mm:54: desired_options = NSApplicationPresentationHideDock |
Should this be AutoHideDock? From what I understand, this wasn't possible with
the old api. +jeremya who wrote the only client of this mode.

https://codereview.chromium.org/12052012/diff/1/chrome/browser/fullscreen_mac.mm
File chrome/browser/fullscreen_mac.mm (left):

https://codereview.chromium.org/12052012/diff/1/chrome/browser/fullscreen_mac...
chrome/browser/fullscreen_mac.mm:60: OSStatus status =
InstallApplicationEventHandler(
Did this inform us about fullscreen changes from other processes too? (Say,
npapi flash fullscreen)

[Avi (use Gerrit), 2013-01-23 21:48:21]

https://codereview.chromium.org/12052012/diff/1/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

https://codereview.chromium.org/12052012/diff/1/base/mac/mac_util.mm#newcode54
base/mac/mac_util.mm:54: desired_options = NSApplicationPresentationHideDock |
On 2013/01/23 21:35:21, Nico wrote:
> From what I understand, this wasn't possible with the old api.

Incorrect; it was completely possible with the old API. Auto-hiding the dock was
kUIModeContentSuppressed. Auto-hiding dock+menu was kUIModeAllSuppressed.

The old code here was kUIModeAllHidden+kUIOptionAutoShowMenuBar. That means
completely hide the dock and menu, and then make the menu auto-hide instead.

This new code is the exact equivalent of our old code. Is this not what we want
to do?

https://codereview.chromium.org/12052012/diff/1/chrome/browser/fullscreen_mac.mm
File chrome/browser/fullscreen_mac.mm (left):

https://codereview.chromium.org/12052012/diff/1/chrome/browser/fullscreen_mac...
chrome/browser/fullscreen_mac.mm:60: OSStatus status =
InstallApplicationEventHandler(
On 2013/01/23 21:35:21, Nico wrote:
> Did this inform us about fullscreen changes from other processes too? (Say,
> npapi flash fullscreen)

Yes, and that's the point.

Cocoa has on NSApp both -presentationOptions and
-currentSystemPresentationOptions. The former is the local setting for when this
app is in front, the latter is the global system setting, depending on what the
app that is currently in control has set.

Carbon only has GetSystemUIMode, which gets the local setting for the app. The
only way in Carbon to get the global system setting was to observe and track the
kEventAppSystemUIModeChanged event which was broadcast when the global system
setting changed. That's why we had this class in the first place.

[Nico, 2013-01-23 21:52:08]

ok, lgtm

https://codereview.chromium.org/12052012/diff/1/chrome/browser/fullscreen_mac.mm
File chrome/browser/fullscreen_mac.mm (right):

https://codereview.chromium.org/12052012/diff/1/chrome/browser/fullscreen_mac...
chrome/browser/fullscreen_mac.mm:32: (options &
NSApplicationPresentationAutoHideMenuBar))) {
nit: This would be a tad more readable as

bool dock_hidden = (options & NSApplicationPresentationHideDock) ||
    (options & NSApplicationPresentationAutoHideDock);

bool menu_hidden = (options & NSApplicationPresentationHideMenuBar) ||
    (options & NSApplicationPresentationAutoHideMenuBar);

if (dock_hidden && menu_hidden) …

[Avi (use Gerrit), 2013-01-23 21:55:07]

https://codereview.chromium.org/12052012/diff/1/chrome/browser/fullscreen_mac.mm
File chrome/browser/fullscreen_mac.mm (right):

https://codereview.chromium.org/12052012/diff/1/chrome/browser/fullscreen_mac...
chrome/browser/fullscreen_mac.mm:32: (options &
NSApplicationPresentationAutoHideMenuBar))) {
agreed.

[commit-bot: I haz the power, 2013-01-23 21:59:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/12052012/8001

[commit-bot: I haz the power, 2013-01-24 01:43:01]

Change committed as 178470