Switch to Cocoa APIs for fullscreen.

Switch to Cocoa APIs for fullscreen.

BUG=none
TEST=none
TBR=thakis@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174754

[Avi (use Gerrit), 2012-12-28 05:23:10]

https://codereview.chromium.org/11697004/diff/1/ui/base/cocoa/fullscreen_wind...
File ui/base/cocoa/fullscreen_window_manager_unittest.mm (right):

https://codereview.chromium.org/11697004/diff/1/ui/base/cocoa/fullscreen_wind...
ui/base/cocoa/fullscreen_window_manager_unittest.mm:25:
EXPECT_EQ((NSApplicationPresentationOptions)
Without this I get an error comparing unsigned to signed. Makes no sense.

[Avi (use Gerrit), 2012-12-28 20:04:51]

Robert is in the office.

I tested on 10.6 and 10.8.

[Robert Sesek, 2012-12-28 20:18:54]

https://codereview.chromium.org/11697004/diff/1/chrome/browser/fullscreen_mac.mm
File chrome/browser/fullscreen_mac.mm (right):

https://codereview.chromium.org/11697004/diff/1/chrome/browser/fullscreen_mac...
chrome/browser/fullscreen_mac.mm:30: (options &
NSApplicationPresentationAutoHideMenuBar)))
nit: needs {} since the condition is multi-line

https://codereview.chromium.org/11697004/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/11697004/diff/1/chrome/chrome_browser.gypi#ne...
chrome/chrome_browser.gypi:2874: '../third_party/GTM/DebugUtils',
What's this needed for?

https://codereview.chromium.org/11697004/diff/1/ui/base/cocoa/fullscreen_wind...
File ui/base/cocoa/fullscreen_window_manager_unittest.mm (right):

https://codereview.chromium.org/11697004/diff/1/ui/base/cocoa/fullscreen_wind...
ui/base/cocoa/fullscreen_window_manager_unittest.mm:25:
EXPECT_EQ((NSApplicationPresentationOptions)
C++ style cast

[Avi (use Gerrit), 2012-12-28 21:02:39]

All done; please take a look.

https://codereview.chromium.org/11697004/diff/1/chrome/browser/fullscreen_mac.mm
File chrome/browser/fullscreen_mac.mm (right):

https://codereview.chromium.org/11697004/diff/1/chrome/browser/fullscreen_mac...
chrome/browser/fullscreen_mac.mm:30: (options &
NSApplicationPresentationAutoHideMenuBar)))
On 2012/12/28 20:18:54, rsesek wrote:
> nit: needs {} since the condition is multi-line

Done.

https://codereview.chromium.org/11697004/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/11697004/diff/1/chrome/chrome_browser.gypi#ne...
chrome/chrome_browser.gypi:2874: '../third_party/GTM/DebugUtils',
On 2012/12/28 20:18:54, rsesek wrote:
> What's this needed for?

GTMNSObject+KeyValueObserving.m blindly includes "GTMDebugSelectorValidation.h"
which is in DebugUtils.

https://codereview.chromium.org/11697004/diff/1/ui/base/cocoa/fullscreen_wind...
File ui/base/cocoa/fullscreen_window_manager_unittest.mm (right):

https://codereview.chromium.org/11697004/diff/1/ui/base/cocoa/fullscreen_wind...
ui/base/cocoa/fullscreen_window_manager_unittest.mm:25:
EXPECT_EQ((NSApplicationPresentationOptions)
On 2012/12/28 20:18:54, rsesek wrote:
> C++ style cast

Done.

[Robert Sesek, 2012-12-28 21:09:40]

LGTM

https://codereview.chromium.org/11697004/diff/8/chrome/browser/fullscreen_mac.mm
File chrome/browser/fullscreen_mac.mm (right):

https://codereview.chromium.org/11697004/diff/8/chrome/browser/fullscreen_mac...
chrome/browser/fullscreen_mac.mm:24: bool
AreOptionsFullScreen(NSApplicationPresentationOptions options) {
Use ObjC BOOL since this is used as a value for fullScreen_ below

[Avi (use Gerrit), 2012-12-28 21:31:52]

https://codereview.chromium.org/11697004/diff/8/chrome/browser/fullscreen_mac.mm
File chrome/browser/fullscreen_mac.mm (right):

https://codereview.chromium.org/11697004/diff/8/chrome/browser/fullscreen_mac...
chrome/browser/fullscreen_mac.mm:24: bool
AreOptionsFullScreen(NSApplicationPresentationOptions options) {
On 2012/12/28 21:09:40, rsesek wrote:
> Use ObjC BOOL since this is used as a value for fullScreen_ below

Done.

[commit-bot: I haz the power, 2012-12-28 21:32:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/11697004/13002

[commit-bot: I haz the power, 2012-12-28 21:32:07]

Presubmit check for 11697004-13002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    base/mac

Presubmit checks took 1.6s to calculate.

[commit-bot: I haz the power, 2012-12-28 22:51:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/11697004/13002

[commit-bot: I haz the power, 2012-12-29 01:01:18]

Change committed as 174754