Android: removes deprecated |timeout| param from StartMonitoringLogcat.

Android: removes deprecated |timeout| param from StartMonitoringLogcat.

This parameter has been deprecated in favor of WaitForLogMatch.

BUG=171347
TEST=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180396

[bulach, 2013-01-22 02:33:57]

follow up from https://codereview.chromium.org/12035016/, ptal

[bulach, 2013-01-22 02:34:53]

+aberent

[Sami, 2013-01-22 02:36:36]

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:825: pexpect.TIMEOUT upon the timeout
specified by StartMonitoringLogcat().
Also here :)

[bulach, 2013-01-22 02:40:58]

thanks sami! just waiting for the other patch so I can rebase in here..

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:825: pexpect.TIMEOUT upon the timeout
specified by StartMonitoringLogcat().
On 2013/01/22 02:36:37, Sami wrote:
> Also here :)

the other one took care of it :)
as soon as that one lands, I'll rebase with this and mark this comment as done.
https://codereview.chromium.org/12035016/diff/6002/build/android/pylib/androi...

[frankf, 2013-01-22 18:34:22]

LGTM

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:820: |success_re|. If None is given, no
error condition will be detected.
Make this an optional param?

[aberent, 2013-01-29 13:25:08]

lgtm

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:856: (self._logcat.timeout,
success_re.pattern))
I think the timeout here should be "timeout", not "self._logcat.timeout". I have
actually fixed this in parallel in a patch I have submitted for review.

[bulach, 2013-02-04 11:21:23]

thanks all! CQing but happy to follow up if frank has more comments..

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:820: |success_re|. If None is given, no
error condition will be detected.
On 2013/01/22 18:34:22, frankf wrote:
> Make this an optional param?

hmm, making an optional param in the middle is kind of tricky, they should only
be added at the end.. ok to leave as it is?
(tbh, without proper static analysis tools, it'd be safer to  have fewer
optional params rather than more :) we've been bitten a few times by the wrong
params being passed when the optional params aren't properly named / when they
become optional..)

https://codereview.chromium.org/12051006/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:856: (self._logcat.timeout,
success_re.pattern))
On 2013/01/29 13:25:08, aberent wrote:
> I think the timeout here should be "timeout", not "self._logcat.timeout". I
have
> actually fixed this in parallel in a patch I have submitted for review.

thanks! your patch took care of it.. :)

[commit-bot: I haz the power, 2013-02-04 11:22:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/12051006/8001

[commit-bot: I haz the power, 2013-02-04 13:16:40]

Change committed as 180396