Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3282)

Unified Diff: build/android/pylib/android_commands.py

Issue 12051006: Android: removes deprecated |timeout| param from StartMonitoringLogcat. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/android_commands.py
diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py
index 9c2107cb0baa3beedd1a313ea69c77846fa6d1ec..42b67850a6cb20e03786ed43379b20dce4f05218 100644
--- a/build/android/pylib/android_commands.py
+++ b/build/android/pylib/android_commands.py
@@ -808,14 +808,12 @@ class AndroidCommands(object):
assert build_type
return build_type
- def StartMonitoringLogcat(self, clear=True, timeout=10, logfile=None,
- filters=None):
+ def StartMonitoringLogcat(self, clear=True, logfile=None, filters=None):
"""Starts monitoring the output of logcat, for use with WaitForLogMatch.
Args:
clear: If True the existing logcat output will be cleared, to avoiding
matching historical output lurking in the log.
- timeout: Deprecated, will be removed soon.
filters: A list of logcat filters to be used.
"""
if clear:
@@ -834,8 +832,7 @@ class AndroidCommands(object):
# Spawn logcat and syncronize with it.
for _ in range(4):
- self._logcat = pexpect.spawn('adb', args, timeout=timeout,
- logfile=logfile)
+ self._logcat = pexpect.spawn('adb', args, timeout=10, logfile=logfile)
self.RunShellCommand('log startup_sync')
if self._logcat.expect(['startup_sync', pexpect.EOF,
pexpect.TIMEOUT]) == 0:
@@ -874,7 +871,7 @@ class AndroidCommands(object):
t0 = time.time()
while True:
if not self._logcat:
- self.StartMonitoringLogcat(clear, timeout=timeout)
+ self.StartMonitoringLogcat(clear)
try:
while True:
# Note this will block for upto the timeout _per log line_, so we need
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698