git_cl.py - Issue 12047089: Make gcl commit/git cl dcommit append a commit notification to rietveld.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 12047089: Make gcl commit/git cl dcommit append a commit notification to rietveld. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Add a helpful note when presubmits were run on the commit Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index aba28f6746c3e40a95a1e674156f8ce3982c02c1..7ccf28d58af171fab2042d8c32937854155664b9 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -612,6 +612,11 @@ or verify this branch is set up to track another (via the --track argument to

return wrapper.fill(self.description)

return self.description

+ def AddComment(self, comment):

M-A Ruel 2013/01/25 23:28:43 This method doesn't add much, you can as well just

iannucci 2013/01/25 23:33:00 Ok, sgtm. I wasn't sure about consistency/style. S

M-A Ruel 2013/01/25 23:47:10 gcl and git_cl.py are completely separate, no need

+ """Adds a comment for an issue on Rietveld.

+ As a side effect, this will email everyone associated with the issue."""

+ return self.RpcServer().add_comment(self.GetIssue(), comment)

def GetPatchset(self):

"""Returns the patchset number as a int or None if not set."""

if not self.has_patchset:

@@ -1495,6 +1500,9 @@ def SendUpstream(parser, args, cmd):

print ('Closing issue '

'(you may be prompted for your codereview password)...')

cl.CloseIssue()

+ comment = "Committed manually as r%s" % revision

+ comment += ' (presubmit successful).' if not options.bypass_hooks else '.'

+ cl.AddComment(comment)

cl.SetIssue(0)

if retcode == 0:

« no previous file with comments | « gcl.py ('k') | tests/gcl_unittest.py » ('j') | no next file with comments »