chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc - Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

index 6a3f14942c5ff320545032e7b7ce3b2abeaacbc7..75aa59f86ae1c61817163b0ca0a786980e953077 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

@@ -21,8 +21,7 @@ TEST_F(ExtensionManifestTest, ValidApp) {

TEST_F(ExtensionManifestTest, AllowUnrecognizedPermissions) {

std::string error;

- scoped_ptr<DictionaryValue> manifest(

- LoadManifestFile("valid_app.json", &error));

+ scoped_ptr<DictionaryValue> manifest(LoadManifest("valid_app.json", &error));

ListValue* permissions = NULL;

ASSERT_TRUE(manifest->GetList("permissions", &permissions));

permissions->Append(new StringValue("not-a-valid-permission"));