Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3400)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc
index f579b56527c792fed7351493fc65976716f9b88e..3cb9e909e146cbfcbd65ad33be9aff78ce42cb93 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc
@@ -2,11 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-
#include "chrome/common/extensions/api/extension_action/browser_action_handler.h"
+#include "chrome/common/extensions/api/extension_action/page_action_handler.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
#include "chrome/common/extensions/manifest_handler.h"
+#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
@@ -16,6 +16,12 @@ class UIManifestTest : public ExtensionManifestTest {
virtual void SetUp() OVERRIDE {
ManifestHandler::Register(extension_manifest_keys::kBrowserAction,
make_linked_ptr(new BrowserActionHandler));
+ linked_ptr<extensions::PageActionHandler> page_action_handler(
+ new extensions::PageActionHandler);
+ extensions::ManifestHandler::Register(
+ extension_manifest_keys::kPageAction, page_action_handler);
+ extensions::ManifestHandler::Register(
+ extension_manifest_keys::kPageActions, page_action_handler);
}
};

Powered by Google App Engine
This is Rietveld 408576698