Issue 12041015: Use proper histogram macros for Renderer4 histograms.

Issue 12041015: Use proper histogram macros for Renderer4 histograms. (Closed)

Created:
7 years, 11 months ago by Ilya Sherman

Modified:
7 years, 11 months ago

Reviewers:
jamesr

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use proper histogram macros for Renderer4 histograms. BUG=164518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178008

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -16 lines)			Patch
M	cc/content_layer.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	cc/frame_rate_counter.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	cc/overdraw_metrics.cc	View	1 chunk	+45 lines, -11 lines	0 comments	Download
M	cc/texture_uploader.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm I think Brian had a similar fix on the pipe, not sure what happened ...

7 years, 11 months ago (2013-01-22 09:38:46 UTC) #2

lgtm

I think Brian had a similar fix on the pipe, not sure what happened to it.
On Jan 22, 2013 1:08 AM, <isherman@chromium.org> wrote:

> Reviewers: jamesr,
>
> Description:
> Use proper histogram macros for Renderer4 histograms.
>
> BUG=164518
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/12041015/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M cc/content_layer.cc
>   M cc/frame_rate_counter.cc
>   M cc/overdraw_metrics.cc
>   M cc/texture_uploader.cc
>
>
> Index: cc/content_layer.cc
> diff --git a/cc/content_layer.cc b/cc/content_layer.cc
> index a0ddc89515e484158182c89937e219**14f400a27e..**
> 4b051ad6dd671e8cefcd700d89e1b3**23ff82244b 100644
> --- a/cc/content_layer.cc
> +++ b/cc/content_layer.cc
> @@ -32,8 +32,11 @@ void ContentLayerPainter::paint(**SkCanvas* canvas,
> gfx::Rect contentRect, gfx::Re
>      m_client->paintContents(**canvas, contentRect, opaque);
>      base::TimeTicks paintEnd = base::TimeTicks::HighResNow();
>      double pixelsPerSec = (contentRect.width() * contentRect.height()) /
> (paintEnd - paintStart).InSecondsF();
> -    HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**AccelContentPaintDurationMS",
> (paintEnd - paintStart).InMilliseconds(), 0, 120, 30);
> -    HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**AccelContentPaintMegapixPerSec
> **ond", pixelsPerSec / 1000000, 10, 210, 30);
> +    UMA_HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**
> AccelContentPaintDurationMS",
> +                                (paintEnd - paintStart).InMilliseconds(),
> +                                0, 120, 30);
> +    UMA_HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**
> AccelContentPaintMegapixPerSec**ond",
> +                                pixelsPerSec / 1000000, 10, 210, 30);
>  }
>
>  const int ContentLayer::**kLCDTextMaxChangeCount = 1;
> Index: cc/frame_rate_counter.cc
> diff --git a/cc/frame_rate_counter.cc b/cc/frame_rate_counter.cc
> index a835d42c52ecef4d44d1a98f3de24f**97e67752e3..**
> 3628d789ec302757b2bceeb7d6e180**c6bdea7022 100644
> --- a/cc/frame_rate_counter.cc
> +++ b/cc/frame_rate_counter.cc
> @@ -42,8 +42,11 @@ void FrameRateCounter::**saveTimeStamp(base::TimeTicks
> timestamp)
>
>      base::TimeDelta frameIntervalSeconds =
recentFrameInterval(m_**ringBuffer.BufferSize()
> - 1);
>
> -    if (m_hasImplThread && m_ringBuffer.CurrentIndex() > 0)
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**
> CompositorThreadImplDrawDelay"**, frameIntervalSeconds.**InMilliseconds(),
> 1, 120, 60);
> +    if (m_hasImplThread && m_ringBuffer.CurrentIndex() > 0) {
> +        UMA_HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**
> CompositorThreadImplDrawDelay"**,
> +                                    frameIntervalSeconds.**
> InMilliseconds(),
> +                                    1, 120, 60);
> +    }
>
>      if (!isBadFrameInterval(**frameIntervalSeconds) &&
>          frameIntervalSeconds.**InSecondsF() > kDroppedFrameTime)
> Index: cc/overdraw_metrics.cc
> diff --git a/cc/overdraw_metrics.cc b/cc/overdraw_metrics.cc
> index 8f4df245ed0a6a5ff181d3d6a509d8**6a57bce357..**
> 40dbd653da672cf5ffd892f2ff6e6b**f371ca39e4 100644
> --- a/cc/overdraw_metrics.cc
> +++ b/cc/overdraw_metrics.cc
> @@ -144,23 +144,57 @@ void
OverdrawMetrics::**recordMetricsInternal(**MetricsType
> metricsType, const Layer
>
>      switch (metricsType) {
>      case DrawingToScreen: {
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.pixelCountOpaque_**Draw",
> static_cast<int>(normalization * m_pixelsDrawnOpaque), 100, 1000000, 50);
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**pixelCountTranslucent_Draw",
> static_cast<int>(normalization * m_pixelsDrawnTranslucent), 100, 1000000,
> 50);
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.pixelCountCulled_**Draw",
> static_cast<int>(normalization * m_pixelsCulledForDrawing), 100, 1000000,
> 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.pixelCountOpaque_**Draw",
> +            static_cast<int>(normalization * m_pixelsDrawnOpaque),
> +            100, 1000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.**pixelCountTranslucent_Draw",
> +            static_cast<int>(normalization * m_pixelsDrawnTranslucent),
> +            100, 1000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.pixelCountCulled_**Draw",
> +            static_cast<int>(normalization * m_pixelsCulledForDrawing),
> +            100, 1000000, 50);
>
>          TRACE_COUNTER_ID1("cc", "DrawPixelsCulled", layerTreeHost,
> m_pixelsCulledForDrawing);
>          TRACE_EVENT2("cc", "OverdrawMetrics", "PixelsDrawnOpaque",
> m_pixelsDrawnOpaque, "PixelsDrawnTranslucent", m_pixelsDrawnTranslucent);
>          break;
>      }
>      case UpdateAndCommit: {
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.pixelCountPainted",
> static_cast<int>(normalization * m_pixelsPainted), 100, 1000000, 50);
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.pixelCountOpaque_**Upload",
> static_cast<int>(normalization * m_pixelsUploadedOpaque), 100, 1000000, 50);
> -       
HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**pixelCountTranslucent_Upload",
> static_cast<int>(normalization * m_pixelsUploadedTranslucent), 100,
> 1000000, 50);
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.tileCountCulled_**Upload",
> static_cast<int>(**tileNormalization * m_tilesCulledForUpload), 100,
> 10000000, 50);
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**renderSurfaceTextureBytes_
> **ViewportScaled", static_cast<int>(**byteNormalization *
m_**renderSurfaceTextureUseBytes),
> 10, 1000000, 50);
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**renderSurfaceTextureBytes_
> **Unscaled", static_cast<int>(m_**renderSurfaceTextureUseBytes / 1000),
> 1000, 100000000, 50);
> -       
HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**contentsTextureBytes_**ViewportScaled",
> static_cast<int>(**byteNormalization * m_contentsTextureUseBytes), 10,
> 1000000, 50);
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**
> contentsTextureBytes_Unscaled"**,
static_cast<int>(m_**contentsTextureUseBytes
> / 1000), 1000, 100000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.pixelCountPainted",
> +            static_cast<int>(normalization * m_pixelsPainted),
> +            100, 1000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.pixelCountOpaque_**Upload",
> +            static_cast<int>(normalization * m_pixelsUploadedOpaque),
> +            100, 1000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.**pixelCountTranslucent_Upload",
> +            static_cast<int>(normalization * m_pixelsUploadedTranslucent),
> +            100, 1000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.tileCountCulled_**Upload",
> +            static_cast<int>(**tileNormalization *
> m_tilesCulledForUpload),
> +            100, 10000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.**renderSurfaceTextureBytes_**ViewportScaled",
> +            static_cast<int>(
> +                byteNormalization * m_**renderSurfaceTextureUseBytes),
> +            10, 1000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.**renderSurfaceTextureBytes_**Unscaled",
> +            static_cast<int>(m_**renderSurfaceTextureUseBytes / 1000),
> +            1000, 100000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.**contentsTextureBytes_**ViewportScaled",
> +            static_cast<int>(**byteNormalization *
> m_contentsTextureUseBytes),
> +            10, 1000000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS(
> +            "Renderer4.**contentsTextureBytes_Unscaled"**,
> +            static_cast<int>(m_**contentsTextureUseBytes / 1000),
> +            1000, 100000000, 50);
>
>          {
>              TRACE_COUNTER_ID1("cc", "UploadTilesCulled", layerTreeHost,
> m_tilesCulledForUpload);
> Index: cc/texture_uploader.cc
> diff --git a/cc/texture_uploader.cc b/cc/texture_uploader.cc
> index bb4cdfe32e5eb82c1f78e78fe588a5**fa8b678406..**
> 56e73472ca62c3a6c60492d60d2e83**b2e50b168f 100644
> --- a/cc/texture_uploader.cc
> +++ b/cc/texture_uploader.cc
> @@ -348,7 +348,8 @@ void TextureUploader::**processQueries()
>              break;
>
>          unsigned usElapsed = m_pendingQueries.front()->**value();
> -        HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**TextureGpuUploadTimeUS",
> usElapsed, 0, 100000, 50);
> +        UMA_HISTOGRAM_CUSTOM_COUNTS("**Renderer4.**
> TextureGpuUploadTimeUS",
> +                                    usElapsed, 0, 100000, 50);
>
>          // Clamp the queries to saner values in case the queries fail.
>          usElapsed = std::max(1u, usElapsed);
>
>
>

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/12041015/1

7 years, 11 months ago (2013-01-22 09:42:42 UTC) #3

Message was sent while issue was closed.

Change committed as 178008

Expand Messages | Collapse Messages