Log event start and event end separately when using --log-timer-events.

Log event start and event end separately when using --log-timer-events.


R=haraken@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13529

[haraken, 2013-01-28 12:35:49]

LGTM for files other than plot-timer-events.js. I'd like to have some V8 expert
(who has reviewed plot-timer-events.js) take a look at plot-timer-events.js.

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js
File tools/plot-timer-events.js (right):

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:85: return this[this.length-1];
Nit: this.length - 1 (Spaces needed around '-')

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:132: function AccountForDistortionToMs(timestamp) {
I don't fully understand what 'AccountForDistortionToMs' means. Maybe
'AlignTimestampToMillisecondResolution' ?

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:174: // Find out about the thread_id.
Nit: Find out the thread_id.

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:175: var finished_event = TimerEvents[name];
if (finished_event === undefined) return;

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:181: assert(finished_event ===
event_stack[thread_id].pop());
I want to make the error message more verbose e.g. what event is not balanced in
the log. You can pass a debug message to assert().

[Jakob Kummerow, 2013-01-28 14:40:08]

plot-timer-events.js LGTM (if you address haraken's comments).

[Yang, 2013-01-28 14:42:53]

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js
File tools/plot-timer-events.js (right):

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:85: return this[this.length-1];
On 2013/01/28 12:35:49, haraken1 wrote:
> Nit: this.length - 1 (Spaces needed around '-')

Done.

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:132: function AccountForDistortionToMs(timestamp) {
On 2013/01/28 12:35:49, haraken1 wrote:
> I don't fully understand what 'AccountForDistortionToMs' means. Maybe
> 'AlignTimestampToMillisecondResolution' ?

I changed that into parseTimeStamp used in CollectData(). It combines conversion
to milliseconds and accounts for distortion.

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:174: // Find out about the thread_id.
On 2013/01/28 12:35:49, haraken1 wrote:
> Nit: Find out the thread_id.

Done.

https://codereview.chromium.org/12040075/diff/5001/tools/plot-timer-events.js...
tools/plot-timer-events.js:175: var finished_event = TimerEvents[name];
On 2013/01/28 12:35:49, haraken1 wrote:
> if (finished_event === undefined) return;

This should never happen, as asserted below. I moved up that assertion.