Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: src/counters.cc

Issue 12040075: Log event start and event end separately when using --log-timer-events. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/log.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 } 70 }
71 } 71 }
72 72
73 void* Histogram::CreateHistogram() const { 73 void* Histogram::CreateHistogram() const {
74 return Isolate::Current()->stats_table()-> 74 return Isolate::Current()->stats_table()->
75 CreateHistogram(name_, min_, max_, num_buckets_); 75 CreateHistogram(name_, min_, max_, num_buckets_);
76 } 76 }
77 77
78 // Start the timer. 78 // Start the timer.
79 void HistogramTimer::Start() { 79 void HistogramTimer::Start() {
80 if (histogram_.Enabled() || FLAG_log_internal_timer_events) { 80 if (histogram_.Enabled()) {
81 stop_time_ = 0; 81 stop_time_ = 0;
82 start_time_ = OS::Ticks(); 82 start_time_ = OS::Ticks();
83 } 83 }
84 if (FLAG_log_internal_timer_events) {
85 LOG(Isolate::Current(), TimerEvent(Logger::START, histogram_.name_));
86 }
84 } 87 }
85 88
86 // Stop the timer and record the results. 89 // Stop the timer and record the results.
87 void HistogramTimer::Stop() { 90 void HistogramTimer::Stop() {
88 if (histogram_.Enabled()) { 91 if (histogram_.Enabled()) {
89 stop_time_ = OS::Ticks(); 92 stop_time_ = OS::Ticks();
90 // Compute the delta between start and stop, in milliseconds. 93 // Compute the delta between start and stop, in milliseconds.
91 int milliseconds = static_cast<int>(stop_time_ - start_time_) / 1000; 94 int milliseconds = static_cast<int>(stop_time_ - start_time_) / 1000;
92 histogram_.AddSample(milliseconds); 95 histogram_.AddSample(milliseconds);
93 } 96 }
94 if (FLAG_log_internal_timer_events) { 97 if (FLAG_log_internal_timer_events) {
95 LOG(Isolate::Current(), 98 LOG(Isolate::Current(), TimerEvent(Logger::END, histogram_.name_));
96 TimerEvent(histogram_.name_, start_time_, OS::Ticks()));
97 } 99 }
98 } 100 }
99 101
100 } } // namespace v8::internal 102 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698