Issue 12040027: Print an error message if git crup doesn't run hooks because of an error

Issue 12040027: Print an error message if git crup doesn't run hooks because of an error (Closed)

Created:
7 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 11 months ago

Reviewers:
szager1

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Print an error message if git crup doesn't run hooks because of an error BUG=171501 R=szager@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=178357

Patch Set 3 : updates #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	git-crup	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

szager1

I like this, but I think it should always print the error message, rather than ...

7 years, 11 months ago (2013-01-23 19:06:27 UTC) #2

jochen (gone - plz use gerrit)

done. While testing this, I also discovered another bug fixed here: https://codereview.chromium.org/12040046/

7 years, 11 months ago (2013-01-23 19:45:21 UTC) #3

szager1

lgtm with nit https://codereview.chromium.org/12040027/diff/4001/git-crup File git-crup (right): https://codereview.chromium.org/12040027/diff/4001/git-crup#newcode145 git-crup:145: Run 'git submodule status' to see ...

7 years, 11 months ago (2013-01-23 19:58:13 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12040027/5002

7 years, 11 months ago (2013-01-23 19:59:48 UTC) #5

Message was sent while issue was closed.

Change committed as 178357

Expand Messages | Collapse Messages