Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: git-crup

Issue 12040027: Print an error message if git crup doesn't run hooks because of an error (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: updates Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git-crup
diff --git a/git-crup b/git-crup
index 6f7f533fca1924300b6bb7f8e3033d062cf8a339..d07a4283d54b6429415d7656a390bb4a33158b57 100755
--- a/git-crup
+++ b/git-crup
@@ -139,7 +139,15 @@ fi
status=$?
-if [ "$hooks" = "yes" -a "$status" -eq 0 ]; then
+if [ "$status" -ne 0 ]; then
+ cat 1>&2 <<EOF
+Please check the preceding terminal output for error messages.
+Run 'git submodule status' to see the current state of submodule checkouts.
+EOF
+ exit $status
+fi
+
+if [ "$hooks" = "yes" ]; then
"$runhooks"
status=$?
fi
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698