Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 12039019: Introduce bypass logic for SetCursorLocation message. (Closed)

Created:
7 years, 11 months ago by Seigo Nonaka
Modified:
7 years, 11 months ago
Reviewers:
satorux1
CC:
chromium-reviews, James Su, stevenjb+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Introduce bypass logic for SetCursorLocation message. This CL is second try of https://codereview.chromium.org/12017010/ Current Chrome does not emit SetCursorLocation message to ibus-daemon because both candidate window and input context is in same process. It was achieved by injecting IBusClient into ui::InputMethodIBus, but we are now able to bypass them only in chromeos/ directory. With this refactoring, we can remove ui::internal::IBusClient, IBusChromeOSClientImpl and their injection code. This patch introduces bypass code for SetCursorLocation, but not used yet. BUG=None TEST=Manually done on lumpy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178543

Patch Set 1 : base patch #

Patch Set 2 : disable some unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -63 lines) Patch
M chromeos/dbus/dbus_thread_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_constants.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.h View 5 chunks +18 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.cc View 8 chunks +53 lines, -12 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client_unittest.cc View 5 chunks +28 lines, -30 lines 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service.h View 3 chunks +7 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service.cc View 5 chunks +17 lines, -4 lines 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service_unittest.cc View 4 chunks +10 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/mock_ibus_input_context_client.h View 2 chunks +7 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/mock_ibus_input_context_client.cc View 3 chunks +16 lines, -1 line 0 comments Download
M ui/base/ime/ibus_client.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M ui/base/ime/input_method_ibus_unittest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
Sorry previous patch breaks ui_unittests and close tree. The reason for breakage is I forget ...
7 years, 11 months ago (2013-01-22 11:58:24 UTC) #1
satorux1
When you are relanding, please upload the original patch as Patch Set 1, then upload ...
7 years, 11 months ago (2013-01-22 17:24:59 UTC) #2
satorux1
7 years, 11 months ago (2013-01-22 17:25:08 UTC) #3
Seigo Nonaka
Sorry for unclear review. I uploaded base patch. Please take an another look? Thank you.
7 years, 11 months ago (2013-01-23 04:53:10 UTC) #4
satorux1
LGTM
7 years, 11 months ago (2013-01-23 17:43:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12039019/5002
7 years, 11 months ago (2013-01-24 03:48:40 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-24 07:21:00 UTC) #7
Message was sent while issue was closed.
Change committed as 178543

Powered by Google App Engine
This is Rietveld 408576698