Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 12038055: Move visitedlink and auto_login_parser to component test target (Closed)

Created:
7 years, 11 months ago by boliu
Modified:
7 years, 11 months ago
Reviewers:
Nico, kaiwang, frankf, Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Move visitedlink and auto_login_parser to component test target BUG=168716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178777

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase, remove unneeded conditions. #

Patch Set 3 : Removed duplicated include #

Patch Set 4 : Rename profile->context, add content_resources.pak on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M build/android/pylib/gtest/test_package.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M components/components_tests.gypi View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M components/visitedlink/test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M components/visitedlink/test/visitedlink_unittest.cc View 1 2 3 11 chunks +37 lines, -41 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
boliu
I think components_unittests are running on all the bots except android now? Do you need ...
7 years, 11 months ago (2013-01-24 02:14:38 UTC) #1
Jói
LGTM Kai knows more about the components_unittests target on bots. Would be great to get ...
7 years, 11 months ago (2013-01-24 11:01:55 UTC) #2
kaiwang
On 2013/01/24 02:14:38, boliu wrote: > I think components_unittests are running on all the bots ...
7 years, 11 months ago (2013-01-24 19:49:26 UTC) #3
kaiwang
https://codereview.chromium.org/12038055/diff/1/components/components_tests.gypi File components/components_tests.gypi (right): https://codereview.chromium.org/12038055/diff/1/components/components_tests.gypi#newcode34 components/components_tests.gypi:34: ['OS != "ios"', { The whole target will not ...
7 years, 11 months ago (2013-01-24 19:49:30 UTC) #4
boliu
Rebased onto my other patch and fixed comments.
7 years, 11 months ago (2013-01-24 20:28:50 UTC) #5
kaiwang
lgtm
7 years, 11 months ago (2013-01-24 21:02:00 UTC) #6
boliu
Frank: build/android, components_unittests uses the same harness as content_unittests so needs the resources pak Nico: ...
7 years, 11 months ago (2013-01-25 02:00:26 UTC) #7
frankf
lgtm to build/android change.
7 years, 11 months ago (2013-01-25 02:30:07 UTC) #8
Nico
chrome/chrome_tests_unit.gypi lgtm
7 years, 11 months ago (2013-01-25 03:13:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/12038055/9003
7 years, 11 months ago (2013-01-25 03:36:03 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 07:54:04 UTC) #11
Message was sent while issue was closed.
Change committed as 178777

Powered by Google App Engine
This is Rietveld 408576698