Fix crash on spell check "Ask Google for suggestions"

Fix crash on spell check "Ask Google for suggestions"

POST COMMIT EDIT:
In order to determine if widgets should be created in an Ash/metro context vs. a normal desktop context, erg@ recently introduced Widget::InitParams::context.  There used to be a fallback handler for context being null, but this was removed intentionally in https://codereview.chromium.org/11829040. After the fallback was removed, Widgets that did not have a context or parent would cause a crash.  That's why I added the DCHECK.

* Set a parent window for the confirmation bubble's widget so Aura knows
  on which desktop to place it.
* Add DCHECK to ensure Aura widgets have either a parent or a context to make
  this failure more obvious in the future.
* Added unit test for ConfirmBubbleViews.
* Removed duplicate anchor_point data in the bubble.

BUG=171856
TEST=Added unit_tests ConfirmBubbleViewsTest.CreateAndClose


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178757

[James Cook, 2013-01-24 22:57:52]

Elliot, PTAL.  This fix is a bit of overkill, but it seemed like we should have
better test coverage for the confirmation bubble.  The low-level DCHECK makes me
a little nervous, but I think it's an invariant the function needs.

https://codereview.chromium.org/12036094/diff/1/chrome/browser/ui/views/confi...
File chrome/browser/ui/views/confirm_bubble_views.cc (right):

https://codereview.chromium.org/12036094/diff/1/chrome/browser/ui/views/confi...
chrome/browser/ui/views/confirm_bubble_views.cc:36: set_parent_window(parent);
This is the core change that fixes the crash.

[Elliot Glaysher, 2013-01-24 23:16:57]

+stevenjb: I like James' DCHECKs more here. Both of them may be overkill, but
maybe not.

James: lgtm

https://codereview.chromium.org/12036094/diff/1/chrome/browser/ui/views/confi...
File chrome/browser/ui/views/confirm_bubble_views_unittest.cc (right):

https://codereview.chromium.org/12036094/diff/1/chrome/browser/ui/views/confi...
chrome/browser/ui/views/confirm_bubble_views_unittest.cc:66:
TEST_F(ConfirmBubbleViewsTest, CreateAndClose) {
Thank you.

[stevenjb, 2013-01-24 23:32:33]

https://codereview.chromium.org/12036094/diff/1/ui/views/widget/native_widget...
File ui/views/widget/native_widget_aura.cc (right):

https://codereview.chromium.org/12036094/diff/1/ui/views/widget/native_widget...
ui/views/widget/native_widget_aura.cc:99: DCHECK(params.parent ||
params.context);
nit: Since now at least two devs have been bitten by this, can you add '<<
"InitNativeWidget must provide parent or context"' so that devs can egt some
feedback without running a debugger?

[James Cook, 2013-01-24 23:35:30]

sky, I can haz OWNERS please?

[sky, 2013-01-25 00:52:26]

LGTM

[commit-bot: I haz the power, 2013-01-25 01:08:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/12036094/1

[commit-bot: I haz the power, 2013-01-25 04:55:50]

Change committed as 178757