Fix crash on spell check "Ask Google for suggestions"

chrome/browser/ui/views/confirm_bubble_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/confirm_bubble_views.h"
 
 #include "chrome/browser/ui/confirm_bubble.h"
 #include "chrome/browser/ui/confirm_bubble_model.h"
 #include "grit/ui_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/controls/button/text_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/widget/widget.h"
 
 namespace {
 
 // Maximum width for the message field. We will wrap the message text when its
 // width is wider than this.
 const int kMaxMessageWidth = 400;
 
 }  // namespace
 
-ConfirmBubbleViews::ConfirmBubbleViews(const gfx::Point& anchor_point,
+ConfirmBubbleViews::ConfirmBubbleViews(gfx::NativeView parent,
+                                       const gfx::Point& anchor_point,
                                        ConfirmBubbleModel* model)
     : BubbleDelegateView(NULL, views::BubbleBorder::NONE),
-      anchor_point_(anchor_point),
       model_(model) {
   DCHECK(model);
+  set_anchor_point(anchor_point);
+  set_parent_window(parent);

[James Cook, 2013/01/24 22:57:52]

This is the core change that fixes the crash.

 }
 
 ConfirmBubbleViews::~ConfirmBubbleViews() {
 }
 
 void ConfirmBubbleViews::ButtonPressed(views::Button* sender,
                                        const ui::Event& event) {
   if (sender->tag() == ConfirmBubbleModel::BUTTON_OK)
     model_->Accept();
   else if (sender->tag() == ConfirmBubbleModel::BUTTON_CANCEL)
     model_->Cancel();
   GetWidget()->Close();
 }
 
 void ConfirmBubbleViews::LinkClicked(views::Link* source, int event_flags) {
   model_->LinkClicked();
 }
 
 gfx::Rect ConfirmBubbleViews::GetAnchorRect() {
-  return gfx::Rect(anchor_point_, gfx::Size());
+  return gfx::Rect(anchor_point(), gfx::Size());
 }
 
 void ConfirmBubbleViews::Init() {
   views::GridLayout* layout = new views::GridLayout(this);
   SetLayoutManager(layout);
 
   // Add the icon, the title label and the close button to the first row.
   views::ColumnSet* cs = layout->AddColumnSet(0);
   cs->AddColumn(views::GridLayout::CENTER, views::GridLayout::CENTER, 0,
                 views::GridLayout::USE_PREF, 0, 0);
@@ skipping 87 matching lines @@
       layout->AddView(cancel_button);
     }
   }
 }
 
 namespace chrome {
 
 void ShowConfirmBubble(gfx::NativeView view,
                        const gfx::Point& origin,
                        ConfirmBubbleModel* model) {
-  ConfirmBubbleViews* bubble = new ConfirmBubbleViews(origin, model);
+  ConfirmBubbleViews* bubble = new ConfirmBubbleViews(view, origin, model);
   views::BubbleDelegateView::CreateBubble(bubble);
   bubble->Show();
 }
 
 }  // namespace chrome