Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2717)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 12035100: Use the correct NRWT flag for specifying additional expectations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index 9239ef542e6970115289f76b0610809efd6abc42..98cd6402777ef2f91c1ef937295490984713ff92 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -209,8 +209,8 @@ def RunWebkitLayoutTests(options):
options.factory_properties.get(flag)])
for f in options.factory_properties.get('additional_expectations_files', []):
- cmd_args.extend(['--additional-expectations-file',
- os.path.join(CHROME_SRC, *f)])
+ cmd_args.extend(
+ ['--additional-expectations=%s' % os.path.join(CHROME_SRC, *f)])
Isaac (away) 2013/01/25 18:28:40 Nit: 4 spaces indentation here
jochen (gone - plz use gerrit) 2013/01/25 20:03:39 that is already 4?
Isaac (away) 2013/01/25 20:09:51 sorry, browser rendering fail. Carry on.
RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py'] + cmd_args)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698