Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: build/android/buildbot/bb_device_steps.py

Issue 12035100: Use the correct NRWT flag for specifying additional expectations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import collections 6 import collections
7 import glob 7 import glob
8 import json 8 import json
9 import multiprocessing 9 import multiprocessing
10 import optparse 10 import optparse
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 '--master-name', options.build_properties.get('mastername', ''), 202 '--master-name', options.build_properties.get('mastername', ''),
203 '--build-name', options.build_properties.get('buildername', ''), 203 '--build-name', options.build_properties.get('buildername', ''),
204 '--platform=chromium-android'] 204 '--platform=chromium-android']
205 205
206 for flag in 'test_results_server', 'driver_name', 'additional_drt_flag': 206 for flag in 'test_results_server', 'driver_name', 'additional_drt_flag':
207 if flag in options.factory_properties: 207 if flag in options.factory_properties:
208 cmd_args.extend(['--%s' % flag.replace('_', '-'), 208 cmd_args.extend(['--%s' % flag.replace('_', '-'),
209 options.factory_properties.get(flag)]) 209 options.factory_properties.get(flag)])
210 210
211 for f in options.factory_properties.get('additional_expectations_files', []): 211 for f in options.factory_properties.get('additional_expectations_files', []):
212 cmd_args.extend(['--additional-expectations-file', 212 cmd_args.extend(
213 os.path.join(CHROME_SRC, *f)]) 213 ['--additional-expectations=%s' % os.path.join(CHROME_SRC, *f)])
Isaac (away) 2013/01/25 18:28:40 Nit: 4 spaces indentation here
jochen (gone - plz use gerrit) 2013/01/25 20:03:39 that is already 4?
Isaac (away) 2013/01/25 20:09:51 sorry, browser rendering fail. Carry on.
214 214
215 RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py'] + cmd_args) 215 RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py'] + cmd_args)
216 216
217 217
218 def MainTestWrapper(options): 218 def MainTestWrapper(options):
219 # Restart adb to work around bugs, sleep to wait for usb discovery. 219 # Restart adb to work around bugs, sleep to wait for usb discovery.
220 RunCmd(['adb', 'kill-server']) 220 RunCmd(['adb', 'kill-server'])
221 RunCmd(['adb', 'start-server']) 221 RunCmd(['adb', 'start-server'])
222 RunCmd(['sleep', '1']) 222 RunCmd(['sleep', '1'])
223 223
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 'slave', 'android')) 319 'slave', 'android'))
320 if os.path.exists(build_internal_android): 320 if os.path.exists(build_internal_android):
321 android_paths.insert(0, build_internal_android) 321 android_paths.insert(0, build_internal_android)
322 os.environ['PATH'] = os.pathsep.join(android_paths + [os.environ['PATH']]) 322 os.environ['PATH'] = os.pathsep.join(android_paths + [os.environ['PATH']])
323 323
324 MainTestWrapper(options) 324 MainTestWrapper(options)
325 325
326 326
327 if __name__ == '__main__': 327 if __name__ == '__main__':
328 sys.exit(main(sys.argv)) 328 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698