Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12035100: Use the correct NRWT flag for specifying additional expectations (Closed)

Created:
7 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 11 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Use the correct NRWT flag for specifying additional expectations BUG=none R=ilevy@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179057

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +2 lines, -2 lines 3 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
7 years, 11 months ago (2013-01-25 12:56:08 UTC) #1
Isaac (away)
lgtm https://codereview.chromium.org/12035100/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/12035100/diff/1/build/android/buildbot/bb_device_steps.py#newcode213 build/android/buildbot/bb_device_steps.py:213: ['--additional-expectations=%s' % os.path.join(CHROME_SRC, *f)]) Nit: 4 spaces indentation ...
7 years, 11 months ago (2013-01-25 18:28:39 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/12035100/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/12035100/diff/1/build/android/buildbot/bb_device_steps.py#newcode213 build/android/buildbot/bb_device_steps.py:213: ['--additional-expectations=%s' % os.path.join(CHROME_SRC, *f)]) On 2013/01/25 18:28:40, Isaac wrote: ...
7 years, 11 months ago (2013-01-25 20:03:39 UTC) #3
Isaac (away)
https://codereview.chromium.org/12035100/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/12035100/diff/1/build/android/buildbot/bb_device_steps.py#newcode213 build/android/buildbot/bb_device_steps.py:213: ['--additional-expectations=%s' % os.path.join(CHROME_SRC, *f)]) On 2013/01/25 20:03:39, jochen wrote: ...
7 years, 11 months ago (2013-01-25 20:09:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12035100/1
7 years, 11 months ago (2013-01-25 20:11:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12035100/1
7 years, 11 months ago (2013-01-26 08:20:04 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-26 08:23:17 UTC) #7
Message was sent while issue was closed. 
Change committed as 179057

Powered by Google App Engine
This is Rietveld 408576698