Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12033058: Updated to most recent version RE2 and remove upstreamed patches. (Closed)

Created:
7 years, 11 months ago by battre
Modified:
7 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Updated to most recent version RE2 and remove upstreamed patches. BUG=169866, 169855, 169851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -246 lines) Patch
D third_party/re2/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/re2/CONTRIBUTORS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/re2/README.chromium View 2 chunks +3 lines, -9 lines 0 comments Download
A third_party/re2/doc/mksyntaxgo View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/re2/doc/syntax.txt View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/re2/patches/fix-implicit-conversion.patch View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/re2/patches/msvc-x64.patch View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/re2/patches/re2-android.patch View 3 chunks +7 lines, -33 lines 0 comments Download
M third_party/re2/patches/re2-msvc9-chrome.patch View 17 chunks +58 lines, -58 lines 0 comments Download
M third_party/re2/patches/remove-static-initializers.patch View 3 chunks +11 lines, -11 lines 0 comments Download
D third_party/re2/patches/remove-testinstall.cc-and-fix-filepermissions.patch View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/re2/patches/remove-valgrind-code.patch View 3 chunks +10 lines, -28 lines 0 comments Download
M third_party/re2/patches/rename-posix-option.patch View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/re2/re2/dfa.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/re2/re2/filtered_re2.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/re2/re2/parse.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/re2/re2/re2.cc View 9 chunks +16 lines, -12 lines 0 comments Download
A third_party/re2/testinstall.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/re2/util/logging.h View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/re2/util/util.h View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
Hi Nico, please take a look. The changes are from downloading the upstream version of ...
7 years, 11 months ago (2013-01-23 19:11:57 UTC) #1
Nico
lgtm
7 years, 11 months ago (2013-01-24 01:20:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/12033058/1
7 years, 11 months ago (2013-01-24 09:16:32 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-24 14:53:59 UTC) #4
Message was sent while issue was closed. 
Change committed as 178575

Powered by Google App Engine
This is Rietveld 408576698