Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(94)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/re2/patches/remove-testinstall.cc-and-fix-filepermissions.patch
Issue
12033058
:
Updated to most recent version RE2 and remove upstreamed patches. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set:
Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/re2/.gitignore
third_party/re2/CONTRIBUTORS
third_party/re2/README.chromium
third_party/re2/doc/mksyntaxgo
third_party/re2/doc/syntax.txt
third_party/re2/patches/fix-implicit-conversion.patch
third_party/re2/patches/msvc-x64.patch
third_party/re2/patches/re2-android.patch
third_party/re2/patches/re2-msvc9-chrome.patch
third_party/re2/patches/remove-static-initializers.patch
third_party/re2/patches/remove-testinstall.cc-and-fix-filepermissions.patch
third_party/re2/patches/remove-valgrind-code.patch
third_party/re2/patches/rename-posix-option.patch
third_party/re2/re2/dfa.cc
third_party/re2/re2/filtered_re2.cc
third_party/re2/re2/parse.cc
third_party/re2/re2/re2.cc
third_party/re2/testinstall.cc
third_party/re2/util/logging.h
third_party/re2/util/util.h
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« third_party/re2/patches/remove-static-initializers.patch
('k') |
third_party/re2/patches/remove-valgrind-code.patch »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
diff --git a/third_party/re2/re2/unicode.py b/third_party/re2/re2/unicode.py
2
old mode 100755
3
new mode 100644
4
diff --git a/third_party/re2/testinstall.cc b/third_party/re2/testinstall.cc
5
deleted file mode 100644
6
index 40b7a8a..0000000
7
--- a/third_party/re2/testinstall.cc
8
+++ /dev/null
9
@@ -1,20 +0,0 @@
10
-#include <re2/re2.h>
11
-#include <re2/filtered_re2.h>
12
-#include <stdio.h>
13
-
14
-using namespace re2;
15
-
16
-int main(void) {
17
- FilteredRE2 f;
18
- int id;
19
- f.Add("a.*b.*c", RE2::DefaultOptions, &id);
20
- vector<string> v;
21
- f.Compile(&v);
22
-
23
- if(RE2::FullMatch("axbyc", "a.*b.*c")) {
24
- printf("PASS\n");
25
- return 0;
26
- }
27
- printf("FAIL\n");
28
- return 2;
29
-}
OLD
NEW
« no previous file with comments
|
« third_party/re2/patches/remove-static-initializers.patch
('k') |
third_party/re2/patches/remove-valgrind-code.patch »
('j') |
no next file with comments »
Issue 12033058: Updated to most recent version RE2 and remove upstreamed patches. (Closed)
Created 7 years, 11 months ago by battre
Modified 7 years, 11 months ago
Reviewers: Nico
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 0
This is Rietveld
408576698