Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1202843005: Revert of Added virtualenv for depot_tools (Closed)

Created:
5 years, 6 months ago by Adrian Kuegel
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Visibility:
Public.

Description

Revert of Added virtualenv for depot_tools (patchset #10 id:180001 of https://chromiumcodereview.appspot.com/1200843003/) Reason for revert: Doesn't work, virtualenv is missing in depot_tools checkout. Original issue's description: > Added virtualenv for depot_tools > > R=pgervais@chromium.org > BUG=503067 > TEST=tested on Mac, Windows and Linux bots > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295811 TBR=pgervais@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=503067 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295813

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -345 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -3 lines 0 comments Download
M PRESUBMIT.py View 1 1 chunk +1 line, -2 lines 0 comments Download
D bootstrap/.gitignore View 1 1 chunk +0 lines, -3 lines 0 comments Download
D bootstrap/bootstrap.py View 1 1 chunk +0 lines, -226 lines 0 comments Download
D bootstrap/deps.pyl View 1 1 chunk +0 lines, -15 lines 0 comments Download
D bootstrap/util.py View 1 1 chunk +0 lines, -87 lines 0 comments Download
M update_depot_tools View 1 1 chunk +0 lines, -4 lines 0 comments Download
M update_depot_tools.bat View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Adrian Kuegel
Created Revert of Added virtualenv for depot_tools
5 years, 6 months ago (2015-06-24 08:38:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202843005/1
5 years, 6 months ago (2015-06-24 08:39:09 UTC) #2
commit-bot: I haz the power
Failed to apply patch for update_depot_tools.bat: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 6 months ago (2015-06-24 08:39:18 UTC) #4
Adrian Kuegel
Committed patchset #2 (id:210001) manually as 295813 (presubmit successful).
5 years, 6 months ago (2015-06-24 08:50:45 UTC) #5
pgervais
5 years, 6 months ago (2015-06-24 15:43:56 UTC) #6
Message was sent while issue was closed.
On 2015/06/24 08:50:45, Adrian Kuegel wrote:
> Committed patchset #2 (id:210001) manually as 295813 (presubmit successful).

lgtm

https/crbug.com/503883 has been filed to requested adding virtualenv to
depot_tools. There might be duplicates of this ticket.

Powered by Google App Engine
This is Rietveld 408576698