Issue 12022027: Fixing up Navigator.getUserMedia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12022027: Fixing up Navigator.getUserMedia. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixup of reverted CL- Fixing up Navigator.getUserMedia. - Fixes Navigator.getUserMedia to be cross-platform. - Adds supported checks. - Dartifies the API. First patch is the original, second is the fix. Issue was that I used = for separating named parameters, rather than : (but it works on dart2js!). I think this distinction is lame, and opened a bug that these should use the same separator. Committed: https://code.google.com/p/dart/source/detail?r=17311

Patch Set 1 #

Patch Set 2 : Fixes. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+268 lines, -43 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	6 chunks	+73 lines, -22 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		6 chunks	+55 lines, -8 lines	0 comments	Download
M	tests/html/html.status	View		4 chunks	+4 lines, -0 lines	0 comments	Download
A	tests/html/media_stream_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
D	tools/dom/templates/html/dart2js/impl_Navigator.darttemplate	View		1 chunk	+0 lines, -13 lines	0 comments	Download
A	tools/dom/templates/html/impl/impl_MediaStream.darttemplate	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	tools/dom/templates/html/impl/impl_Navigator.darttemplate	View	1	1 chunk	+79 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Augh! That = vs : gets me every time! 
lgtm.

Expand Messages | Collapse Messages