chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc - Issue 12022002: Fixing activation states from the new launcher. Also adding a whole bunch of unit tests for the new…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc

Issue 12022002: Fixing activation states from the new launcher. Also adding a whole bunch of unit tests for the new… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed problem with ASAN unittest Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc

index e79136e7594f1d4df0c07150ae621fb0848e96a1..01f7792c1e8e26f8a3fcb72f7e220dd731b794a6 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc

@@ -458,7 +458,3 @@ TEST_F(ChromeLauncherControllerPerAppTest, V1AppMenuExecution) {

// TODO(skuhne) Add tests for:

// - V2 apps: create through item in launcher or directly

-// - Tracking correct activation state (seems not to work from unit_test)

-// - Check that browser is always running or active when browser is active

-// - Check that v1 app active shows browser active and app.

-// ..