chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc - Issue 12022002: Fixing activation states from the new launcher. Also adding a whole bunch of unit tests for the new…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc

Issue 12022002: Fixing activation states from the new launcher. Also adding a whole bunch of unit tests for the new… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed problem with ASAN unittest Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h"	5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 440 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
451 scoped_ptr<ui::MenuModel> menu(	451 scoped_ptr<ui::MenuModel> menu(

452 launcher_controller.CreateApplicationMenu(item_gmail));	452 launcher_controller.CreateApplicationMenu(item_gmail));

453 menu->ActivatedAt(3);	453 menu->ActivatedAt(3);

454 }	454 }

455 // Now the active tab should be the second item.	455 // Now the active tab should be the second item.

456 EXPECT_EQ(0, browser()->tab_strip_model()->active_index());	456 EXPECT_EQ(0, browser()->tab_strip_model()->active_index());

457 }	457 }

458	458

459 // TODO(skuhne) Add tests for:	459 // TODO(skuhne) Add tests for:

460 // - V2 apps: create through item in launcher or directly	460 // - V2 apps: create through item in launcher or directly

461 // - Tracking correct activation state (seems not to work from unit_test)

462 // - Check that browser is always running or active when browser is active

463 // - Check that v1 app active shows browser active and app.

464 // ..

OLD	NEW