Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 12013004: alternate ntp: unpinned bookmark bar in ntp (Closed)

Created:
7 years, 11 months ago by kuan
Modified:
7 years, 11 months ago
Reviewers:
sky, dhollowa
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, melevin, tfarina, sreeram, gideonwald, dominich, David Black, samarth+watch_chromium.org, estade+watch_chromium.org, Jered, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

alternate ntp: unpinned bookmark bar in ntp temporarily move the unpinned bmb in ntp back to the top, like in ntp4, until win aura becomes available. this cl is created from git revert of all previous revisions for bottom bmb, manually editing the conflicts, and ignoring reverted files that don't exist anymore. i intentionally consolidate all reverts into 1 cl, so that i only need to work w/ this cl when i have to put back bottom bmb; it's tedious and error-prone to go back multiple revisions, like this time. i then make top unpinned bmb work by shifting down the preview, like content. BUG=170417 TEST=verify per bug rpt Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -547 lines) Patch
M chrome/browser/ui/browser.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 4 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 18 chunks +22 lines, -134 lines 0 comments Download
M chrome/browser/ui/views/detachable_toolbar_view.h View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/ui/views/detachable_toolbar_view.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 11 chunks +4 lines, -206 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.h View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 7 chunks +31 lines, -80 lines 0 comments Download
M chrome/browser/ui/views/frame/contents_container.h View 5 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/frame/contents_container.cc View 6 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/frame/instant_preview_controller_views.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 5 chunks +8 lines, -17 lines 0 comments Download
M ui/views/controls/button/text_button.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/button/text_button.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/single_split_view.h View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/views/controls/single_split_view.cc View 5 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kuan
7 years, 11 months ago (2013-01-17 22:32:48 UTC) #1
sky
LGTM
7 years, 11 months ago (2013-01-17 23:13:39 UTC) #2
dhollowa
LGTM.
7 years, 11 months ago (2013-01-17 23:22:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/12013004/1
7 years, 11 months ago (2013-01-17 23:31:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/12013004/1
7 years, 11 months ago (2013-01-18 03:00:48 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-18 12:46:08 UTC) #6
Message was sent while issue was closed.
Change committed as 177659

Powered by Google App Engine
This is Rietveld 408576698