Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1201213002: Disable WebViewFocusTest on Site Isolation FYI bots. (Closed)

Created:
5 years, 6 months ago by wjmaclean
Modified:
5 years, 6 months ago
Reviewers:
Nico, alexmos, M-A Ruel
CC:
chromium-reviews, nasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebViewFocusTest on Site Isolation FYI bots. The WebViewFocusTest class is based on WebViewTest, which is currently disabled on the Site Isolation FYI bots. Therefore there's no real chance of it working until WebViewTest is fixed for those bots. This CL adds TODOs to both test classes, as well as disabling WebViewFocusTest on the Site Isolation FYI bots as well. BUG=none TBR=jam@chromium.org Committed: https://crrev.com/ee5628b34fdc33b4a070fb65f6617e440ed90dfc Cr-Commit-Position: refs/heads/master@{#335776}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add bug tracking info. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201213002/1
5 years, 6 months ago (2015-06-23 14:50:37 UTC) #3
wjmaclean
alexmos@ - I've discussed this with nasko@, please take a look.
5 years, 6 months ago (2015-06-23 14:50:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-23 15:55:33 UTC) #6
alexmos
LGTM
5 years, 6 months ago (2015-06-23 16:17:28 UTC) #7
Nico
maruel, are these .json files supposed to be updated manually? https://codereview.chromium.org/1201213002/diff/1/chrome/browser/apps/guest_view/web_view_browsertest.cc File chrome/browser/apps/guest_view/web_view_browsertest.cc (right): https://codereview.chromium.org/1201213002/diff/1/chrome/browser/apps/guest_view/web_view_browsertest.cc#newcode358 ...
5 years, 6 months ago (2015-06-23 18:16:13 UTC) #9
M-A Ruel
On 2015/06/23 18:16:13, Nico wrote: > maruel, are these .json files supposed to be updated ...
5 years, 6 months ago (2015-06-23 18:37:25 UTC) #10
Nico
On 2015/06/23 18:37:25, M-A Ruel wrote: > On 2015/06/23 18:16:13, Nico wrote: > > maruel, ...
5 years, 6 months ago (2015-06-23 18:45:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201213002/20001
5 years, 6 months ago (2015-06-23 21:17:52 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-23 22:26:39 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 22:27:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee5628b34fdc33b4a070fb65f6617e440ed90dfc
Cr-Commit-Position: refs/heads/master@{#335776}

Powered by Google App Engine
This is Rietveld 408576698