Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1201213002: Disable WebViewFocusTest on Site Isolation FYI bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add bug tracking info. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 84d41e652f5cfb48b1dfe23b3af5658a2605778a..4df0bf32d890a45a1cb0b735c567f8bbf6b71130 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -353,6 +353,10 @@ class MockDownloadWebContentsDelegate : public content::WebContentsDelegate {
DISALLOW_COPY_AND_ASSIGN(MockDownloadWebContentsDelegate);
};
+// TODO(wjmaclean): Fix this test class at some point so it can be re-enabled on
+// the site isolation bots, and then look at re-enabling WebViewFocusTest when
+// that happens.
+// https://crbug.com/503751
class WebViewTest : public extensions::PlatformAppBrowserTest {
protected:
void SetUp() override {
@@ -2404,6 +2408,9 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestGarbageCollect) {
}
#if defined(USE_AURA)
+// TODO(wjmaclean): when WebViewTest is re-enabled on the site-isolation
+// bots, then re-enable this test class as well.
+// https://crbug.com/503751
class WebViewFocusTest : public WebViewTest {
public:
~WebViewFocusTest() override {}
« no previous file with comments | « no previous file | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698