Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 11975012: Remove support for Live Object List and inspector module. (Closed)

Created:
7 years, 11 months ago by Yang
Modified:
7 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Remove support for Live Object List and inspector module. These were introduced in r7012 and r6379. The reason for this is that both features are not being maintained. They have been out-of-date for a while. Test cases do not exist. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4292 lines) Patch
M Makefile View 1 chunk +0 lines, -4 lines 0 comments Download
M SConstruct View 3 chunks +0 lines, -24 lines 0 comments Download
M build/common.gypi View 2 chunks +0 lines, -9 lines 0 comments Download
M src/SConscript View 2 chunks +0 lines, -2 lines 0 comments Download
M src/d8.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/d8.js View 9 chunks +0 lines, -617 lines 0 comments Download
M src/debug-debugger.js View 5 chunks +0 lines, -123 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.cc View 6 chunks +1 line, -7 lines 0 comments Download
D src/inspector.h View 1 chunk +0 lines, -60 lines 0 comments Download
D src/inspector.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D src/liveobjectlist.h View 1 chunk +0 lines, -319 lines 0 comments Download
D src/liveobjectlist.cc View 1 chunk +0 lines, -2629 lines 0 comments Download
D src/liveobjectlist-inl.h View 1 chunk +0 lines, -126 lines 0 comments Download
M src/mark-compact.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/runtime.cc View 2 chunks +0 lines, -201 lines 0 comments Download
M src/spaces.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8utils.h View 1 chunk +0 lines, -27 lines 0 comments Download
M src/v8utils.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
7 years, 11 months ago (2013-01-16 14:45:13 UTC) #1
Michael Starzinger
7 years, 11 months ago (2013-01-16 15:33:30 UTC) #2
LGTM. An all-red change, I love those. :)

Powered by Google App Engine
This is Rietveld 408576698